Skip to content

provide official opensuse spec file with darktable.changes #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2012
Merged

provide official opensuse spec file with darktable.changes #5

merged 1 commit into from
Jun 1, 2012

Conversation

@madanyang
Copy link
Contributor

For a long time the opensuse spec file in the git sources have not been reflective to the actual opensuse spec file this commits provides the official spec file for opensuse packages

@upegelow upegelow merged commit 7e5d429 into darktable-org:master Jun 1, 2012
@jesperpedersen jesperpedersen mentioned this pull request Oct 1, 2012
Merged
@TurboGit TurboGit mentioned this pull request Mar 18, 2013
Closed
LebedevRI added a commit that referenced this pull request Nov 21, 2014
@LebedevRI
Blend: _blend_colorspace_channels(): raw has 1 channel per pixel
3759088 
This was probably missed (or it was not noticed) in 78fc8af

Fixes:
=================================================================
==19419==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7f31036b66e0 at pc 0x7f31cd73ce7a bp 0x7f3145815a80 sp 0x7f3145815a78
READ of size 4 at 0x7f31036b66e0 thread T57
    #0 0x7f31cd73ce79 in _blend_normal_unbounded /home/lebedevri/darktable/src/develop/blend.c:486
    #1 0x7f31cd744916 in dt_develop_blend_process._omp_fn.6 /home/lebedevri/darktable/src/develop/blend.c:2194
    #2 0x7f31c6ba5715 (/usr/lib/x86_64-linux-gnu/libgomp.so.1+0xd715)
    #3 0x7f31c9db80a3 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x80a3)
    #4 0x7f31c68cdccc in clone (/lib/x86_64-linux-gnu/libc.so.6+0xe5ccc)

0x7f31036b66e0 is located 0 bytes to the right of 89644768-byte region [0x7f30fe138800,0x7f31036b66e0)
allocated by thread T10 here:
    #0 0x7f31cdbd4c9b in __interceptor_posix_memalign (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54c9b)
    #1 0x7f31cd65c18d in dt_alloc_align /home/lebedevri/darktable/src/common/darktable.c:997
    #2 0x7f31cd731cd8 in dt_dev_pixelpipe_cache_get_weighted /home/lebedevri/darktable/src/develop/pixelpipe_cache.c:163
    #3 0x7f31cd7369dd in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:827
    #4 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #5 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #6 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #7 0x7f31cd732c54 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:814
    #8 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #9 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #10 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #11 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #12 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #13 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #14 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #15 0x7f31cd732c54 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:814
    #16 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #17 0x7f31cd732c54 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:814
    #18 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #19 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #20 0x7f31cd732c54 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:814
    #21 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #22 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #23 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #24 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #25 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #26 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #27 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #28 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689
    #29 0x7f31cd732452 in dt_dev_pixelpipe_process_rec /home/lebedevri/darktable/src/develop/pixelpipe_hb.c:689

Thread T57 created by T10 here:
    #0 0x7f31cdba3bba in pthread_create (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x23bba)
    #1 0x7f31c6ba5c56 (/usr/lib/x86_64-linux-gnu/libgomp.so.1+0xdc56)
    #2 0x7f31c6ba17d9 in GOMP_parallel (/usr/lib/x86_64-linux-gnu/libgomp.so.1+0x97d9)
    #3 0x3ed921823dcccccc

Thread T10 created by T0 here:
    #0 0x7f31cdba3bba in pthread_create (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x23bba)
    #1 0x7f31cd6fc149 in dt_control_jobs_init /home/lebedevri/darktable/src/control/jobs.c:512
    #2 0x7f31cd6f1945 in dt_control_init /home/lebedevri/darktable/src/control/control.c:317
    #3 0x7f31cd65fe3c in dt_init /home/lebedevri/darktable/src/common/darktable.c:745
    #4 0x400b7f in main /home/lebedevri/darktable/src/main.c:24
    #5 0x7f31c6809b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)

SUMMARY: AddressSanitizer: heap-buffer-overflow /home/lebedevri/darktable/src/develop/blend.c:486 _blend_normal_unbounded
Shadow bytes around the buggy address:
  0x0fe6a06cec80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0fe6a06cec90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0fe6a06ceca0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0fe6a06cecb0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0fe6a06cecc0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0fe6a06cecd0: 00 00 00 00 00 00 00 00 00 00 00 00[fa]fa fa fa
  0x0fe6a06cece0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0fe6a06cecf0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0fe6a06ced00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0fe6a06ced10: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0fe6a06ced20: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Heap right redzone:      fb
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack partial redzone:   f4
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Contiguous container OOB:fc
  ASan internal:           fe
==19419==ABORTING
LebedevRI added a commit that referenced this pull request May 17, 2015
@LebedevRI
dt_dev_module_remove(): properly remove all history entries related t…
3859f09 
…o module

Fixes following issue: (refs #10455, comment 3)
1. (empty history stack) change exposure
2. add new exposure iop instance
3. change exposure in second instance
4. delete that new instance
5. change exposure in original instance

=================================================================
31502ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6190023d489c at pc 0x7f073823a423 bp 0x7ffd3f9349d0 sp 0x7ffd3f9349c8
READ of size 4 at 0x6190023d489c thread T0
#0 0x7f073823a422 in dt_dev_add_history_item /home/lebedevri/darktable/src/develop/develop.c:557
#1 0x7f0711886433 in exposure_set_white /home/lebedevri/darktable/src/iop/exposure.c:661
#2 0x7f0711886882 in dt_iop_exposure_set_white /home/lebedevri/darktable/src/iop/exposure.c:682
#3 0x7f07118869e2 in exposure_callback /home/lebedevri/darktable/src/iop/exposure.c:827
#4 0x7f0735ee0503 (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x10503)
#5 0x7f0735ef9fa6 in g_signal_emit_valist (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x29fa6)
#6 0x7f0735efae49 in g_signal_emit_by_name (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x2ae49)
#7 0x7f073814fe94 in dt_bauhaus_slider_set_normalized /home/lebedevri/darktable/src/bauhaus/bauhaus.c:1937
#8 0x7f07381535c6 in dt_bauhaus_slider_scroll /home/lebedevri/darktable/src/bauhaus/bauhaus.c:1781
#9 0x7f07379ad41d (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x1ed41d)
#10 0x7f0735ee0503 (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x10503)
#11 0x7f0735ef9a4f in g_signal_emit_valist (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x29a4f)
#12 0x7f0735efa8fe in g_signal_emit (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x2a8fe)
#13 0x7f0737addde3 (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x31dde3)
#14 0x7f07379aad2d (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x1ead2d)
#15 0x7f07379ac93d in gtk_main_do_event (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x1ec93d)
#16 0x7f073754fb11 (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0+0x4fb11)
#17 0x7f0735c09c3c in g_main_context_dispatch (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x49c3c)
#18 0x7f0735c09f1f (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x49f1f)
#19 0x7f0735c0a241 in g_main_loop_run (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4a241)
#20 0x7f07379abbf4 in gtk_main (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x1ebbf4)
#21 0x7f073833ec96 in dt_gui_gtk_run /home/lebedevri/darktable/src/gui/gtk.c:964
#22 0x400cf3 in main /home/lebedevri/darktable/src/main.c:25
#23 0x7f07309e9b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
#24 0x400bd8 (/usr/local/bin/darktable+0x400bd8)

AddressSanitizer can not describe address in more detail (wild memory access suspected).
SUMMARY: AddressSanitizer: heap-buffer-overflow /home/lebedevri/darktable/src/develop/develop.c:557 dt_dev_add_history_item
...
31502ABORTING
LebedevRI added a commit that referenced this pull request May 23, 2015
@LebedevRI
Print: stop leaking printer allocated&&returned by dt_get_printer_info()
7e6db02 
Fixes following LeakSanitizer-detected leaks:

Direct leak of 432 byte(s) in 1 object(s) allocated from:
    #0 0x7ff04e12c74f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7ff04df002dd in dt_get_printer_info /home/lebedevri/darktable/src/common/cups_print.c:51
    #2 0x7ff02b25d4ca
    #3 0x7ff02b261c9a
    #4 0x7ff04de9ac43 in dt_lib_load_modules /home/lebedevri/darktable/src/libs/lib.c:718
    #5 0x7ff04de9d512 in dt_lib_init /home/lebedevri/darktable/src/libs/lib.c:1008
    #6 0x7ff04dc968c7 in dt_init /home/lebedevri/darktable/src/common/darktable.c:889
    #7 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #8 0x7ff046501b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)

Direct leak of 432 byte(s) in 1 object(s) allocated from:
    #0 0x7ff04e12c74f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7ff04df002dd in dt_get_printer_info /home/lebedevri/darktable/src/common/cups_print.c:51
    #2 0x7ff02b25d4ca
    #3 0x7ff02b25e3b2
    #4 0x7ff04b9f0503 (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x10503)
LebedevRI added a commit that referenced this pull request May 23, 2015
@LebedevRI
Accels: free user_data in preset_lib_module_callback_destroyer()
a2c39ca 
That was allocated in dt_accel_connect_preset_lib()

Fixes following LeakSanitizer-detected leak:
Direct leak of 112 byte(s) in 7 object(s) allocated from:
    #0 0x7f6bd60fc74f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7f6bd36ef799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799)
    #2 0x7f6bd5e6ff8a in dt_lib_connect_common_accels /home/lebedevri/darktable/src/libs/lib.c:1103
    #3 0x7f6bd5e731db in dt_view_manager_switch /home/lebedevri/darktable/src/views/view.c:353
    #4 0x7f6bd5cf8572 in _dt_ctl_switch_mode_to /home/lebedevri/darktable/src/control/control.c:630
    #5 0x7f6bd36eac84 in g_main_context_invoke_full (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4ac84)
LebedevRI added a commit that referenced this pull request May 23, 2015
@LebedevRI
Accels: free user_data in preset_iop_module_callback_destroyer()
096731f 
That was allocated in dt_accel_connect_preset_iop()

Fixes following LeakSanitizer-detected leak:
Direct leak of 1616 byte(s) in 101 object(s) allocated from:
    #0 0x7fe9ab77474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7fe9a8d67799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799)
    #2 0x7fe9ab3afe5d in dt_iop_connect_common_accels /home/lebedevri/darktable/src/develop/imageop.c:2784
    #3 0x7fe9874ec398
    #4 0x7fe9ab4ebf54 in dt_view_manager_switch /home/lebedevri/darktable/src/views/view.c:401
    #5 0x7fe9ab370506 in _dt_ctl_switch_mode_to /home/lebedevri/darktable/src/control/control.c:630
    #6 0x7fe9a8d62be4 in g_main_context_invoke_full (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4abe4)
LebedevRI added a commit that referenced this pull request May 23, 2015
@LebedevRI
Imageio: do not forget to gui_cleanup() before unloading storage/format
5deb762 
Probably, this is a regression since cd3ee07

Fixes ~20 LeakSanitizer-detected leaks like:
Direct leak of 88 byte(s) in 1 object(s) allocated from:
    #0 0x7f7afad8c895 in calloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54895)
    #1 0x7f7ad6a500ec (+0x5620ec)
    #2 0x7f7afa94e505 in dt_imageio_load_modules_format /home/lebedevri/darktable/src/common/imageio_module.c:173
    #3 0x7f7afa950a0d in dt_imageio_init /home/lebedevri/darktable/src/common/imageio_module.c:320
    #4 0x7f7afa8f687f in dt_init /home/lebedevri/darktable/src/common/darktable.c:875
    #5 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #6 0x7f7af3161b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)

Direct leak of 304 byte(s) in 3 object(s) allocated from:
    #0 0x7f7afad8c895 in calloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54895)
    #1 0x7f7af837f7f1 in g_malloc0 (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f7f1)
    #2 0x7f7afa9508e3 in dt_imageio_load_modules_storage /home/lebedevri/darktable/src/common/imageio_module.c:306
    #3 0x7f7afa950a15 in dt_imageio_init /home/lebedevri/darktable/src/common/imageio_module.c:321
    #4 0x7f7afa8f687f in dt_init /home/lebedevri/darktable/src/common/darktable.c:875
    #5 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #6 0x7f7af3161b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
LebedevRI added a commit that referenced this pull request May 23, 2015
@LebedevRI
Libs: do not forget to gui_cleanup() before unloading module
f8a22cf 
Fixes a LOT of LeakSanitizer-detected leaks like:
Direct leak of 1056 byte(s) in 1 object(s) allocated from:
    #0 0x7ff08a4f474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7ff067636756
    #2 0x7ff08a262cb7 in dt_lib_load_modules /home/lebedevri/darktable/src/libs/lib.c:718
    #3 0x7ff08a265586 in dt_lib_init /home/lebedevri/darktable/src/libs/lib.c:1008
    #4 0x7ff08a05e8c7 in dt_init /home/lebedevri/darktable/src/common/darktable.c:889
    #5 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #6 0x7ff0828c9b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
LebedevRI added a commit that referenced this pull request May 23, 2015
@LebedevRI
Print: stop leaking dests allocated by cupsGetDests()
be3b2c8 
Fixes several LeakSanitizer-detected leaks like:
Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x7ff195fd474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7ff18e98282d (/usr/lib/x86_64-linux-gnu/libcups.so.2+0x2282d)
    #2 0x7ff18e9845a5 in _cupsGetDests (/usr/lib/x86_64-linux-gnu/libcups.so.2+0x245a5)
    #3 0x7ff18e98553b in cupsGetDests2 (/usr/lib/x86_64-linux-gnu/libcups.so.2+0x2553b)
    #4 0x7ff195da8c8d in dt_get_papers /home/lebedevri/darktable/src/common/cups_print.c:189
    #5 0x7ff16987610e
    #6 0x7ff169879cc2
    #7 0x7ff195d42cb7 in dt_lib_load_modules /home/lebedevri/darktable/src/libs/lib.c:718
    #8 0x7ff195d45586 in dt_lib_init /home/lebedevri/darktable/src/libs/lib.c:1008
    #9 0x7ff195b3e8c7 in dt_init /home/lebedevri/darktable/src/common/darktable.c:889
    #10 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #11 0x7ff18e3a9b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #12 0x400bd8 (/usr/local/bin/darktable+0x400bd8)

Indirect leak of 304 byte(s) in 1 object(s) allocated from:
    #0 0x7ff195fd4a06 in __interceptor_realloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54a06)
    #1 0x7ff18e9a4a58 in cupsAddOption (/usr/lib/x86_64-linux-gnu/libcups.so.2+0x44a58)
    #2 0x7ff18e9847f2 in _cupsGetDests (/usr/lib/x86_64-linux-gnu/libcups.so.2+0x247f2)
    #3 0x7ff18e98553b in cupsGetDests2 (/usr/lib/x86_64-linux-gnu/libcups.so.2+0x2553b)
    #4 0x7ff195da8c8d in dt_get_papers /home/lebedevri/darktable/src/common/cups_print.c:189
    #5 0x7ff16987610e
    #6 0x7ff169879cc2
    #7 0x7ff195d42cb7 in dt_lib_load_modules /home/lebedevri/darktable/src/libs/lib.c:718
    #8 0x7ff195d45586 in dt_lib_init /home/lebedevri/darktable/src/libs/lib.c:1008
    #9 0x7ff195b3e8c7 in dt_init /home/lebedevri/darktable/src/common/darktable.c:889
    #10 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #11 0x7ff18e3a9b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #12 0x400bd8 (/usr/local/bin/darktable+0x400bd8)
LebedevRI added a commit that referenced this pull request May 23, 2015
@LebedevRI
Print: stop leaking dinfo allocated by cupsCopyDestInfo()
ed430c4 
Fixes LeakSanitizer-detected leaks like:
Direct leak of 264 byte(s) in 1 object(s) allocated from:
    #0 0x7fbe6c634895 in calloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54895)
    #1 0x7fbe64fe8def in cupsCopyDestInfo (/usr/lib/x86_64-linux-gnu/libcups.so.2+0x28def)
    #2 0x7fbe6c408d5c in dt_get_papers /home/lebedevri/darktable/src/common/cups_print.c:205
    #3 0x7fbe3fee610e
    #4 0x7fbe3fee9cc2
    #5 0x7fbe6c3a2d07 in dt_lib_load_modules /home/lebedevri/darktable/src/libs/lib.c:718
    #6 0x7fbe6c3a55d6 in dt_lib_init /home/lebedevri/darktable/src/libs/lib.c:1008
    #7 0x7fbe6c19e917 in dt_init /home/lebedevri/darktable/src/common/darktable.c:889
    #8 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #9 0x7fbe64a09b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #10 0x400bd8 (/usr/local/bin/darktable+0x400bd8)
LebedevRI added a commit that referenced this pull request May 23, 2015
@LebedevRI
Print: stop leaking hcon allocated by cupsConnectDest()
5fe6f68 
And 1 related patch sent into CUPS: https://www.cups.org/str.php?L4634

Fixes LeakSanitizer-detected leaks like:
Direct leak of 12808 byte(s) in 1 object(s) allocated from:
    #0 0x7ffb35bc4895 in calloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54895)
    #1 0x7ffb2e58073c (/usr/lib/x86_64-linux-gnu/libcups.so.2+0x3073c)
    #2 0x7ffb2e5834f0 in httpConnect2 (/usr/lib/x86_64-linux-gnu/libcups.so.2+0x334f0)
    #3 0x7ffb2e5739df in cupsConnectDest (/usr/lib/x86_64-linux-gnu/libcups.so.2+0x239df)
    #4 0x7ffb35998d51 in dt_get_papers /home/lebedevri/darktable/src/common/cups_print.c:200
    #5 0x7ffb0947610e
    #6 0x7ffb094763da
    #7 0x7ffb33488503 (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x10503)
    #8 0x7ffb334a1fa6 in g_signal_emit_valist (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x29fa6)
    #9 0x7ffb334a2e49 in g_signal_emit_by_name (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x2ae49)
    #10 0x7ffb35700af9 in dt_bauhaus_combobox_set /home/lebedevri/darktable/src/bauhaus/bauhaus.c:1104
    #11 0x7ffb09479caf
    #12 0x7ffb35932d17 in dt_lib_load_modules /home/lebedevri/darktable/src/libs/lib.c:718
    #13 0x7ffb359355e6 in dt_lib_init /home/lebedevri/darktable/src/libs/lib.c:1008
    #14 0x7ffb3572e927 in dt_init /home/lebedevri/darktable/src/common/darktable.c:889
    #15 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #16 0x7ffb2df99b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #17 0x400bd8 (/usr/local/bin/darktable+0x400bd8)
LebedevRI added a commit that referenced this pull request May 23, 2015
@LebedevRI
dt_ctl_set_display_profile(): free icc buffer we just got if profile …
5cf182b 
…has not changed

Fixes following LeakSanitizer-detected leak:
Direct leak of 1548384 byte(s) in 3 object(s) allocated from:
    #0 0x7f913367474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7f9130c67799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799)
    #2 0x7f91325abb85 (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0+0x53b85)
    #3 0x7f9133274b15 in dt_ctl_set_display_profile /home/lebedevri/darktable/src/control/control.c:199
    #4 0x7f9133391d6e in window_configure /home/lebedevri/darktable/src/gui/gtk.c:625
    #5 0x7f9132a0531c (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x1ed31c)
    #6 0x7f9130f382d4 in g_closure_invoke (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x102d4)
    #7 0x7f9130f4a03b (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x2203b)
    #8 0x7f9130f521a4 in g_signal_emit_valist (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x2a1a4)
    #9 0x7f9130f528fe in g_signal_emit (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x2a8fe)
    #10 0x7f9132b35de3 (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x31dde3)
    #11 0x7f9132a04819 in gtk_main_do_event (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x1ec819)
    #12 0x7f91325a7b11 (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0+0x4fb11)
    #13 0x7f9130c61c3c in g_main_context_dispatch (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x49c3c)
    #14 0x7f9130c61f1f (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x49f1f)
    #15 0x7f9130c62241 in g_main_loop_run (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4a241)
    #16 0x7f9132a03bf4 in gtk_main (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x1ebbf4)
    #17 0x7f913339d36b in dt_gui_gtk_run /home/lebedevri/darktable/src/gui/gtk.c:964
    #18 0x400cf3 in main /home/lebedevri/darktable/src/main.c:25
    #19 0x7f912ba49b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #20 0x400bd8 (/usr/local/bin/darktable+0x400bd8)
LebedevRI added a commit that referenced this pull request May 23, 2015
@LebedevRI
dt_ctl_get_display_profile_colord_callback(): free icc buffer we just…
e9f50c3 
… got if profile has not changed

Fixes following LeakSanitizer-detected leak:
Direct leak of 516129 byte(s) in 1 object(s) allocated from:
    #0 0x7f8c5f2bc74f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7f8c5c8967cb in g_file_get_contents (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x367cb)
    #2 0x7f8c5eeb809a in dt_ctl_get_display_profile_colord_callback /home/lebedevri/darktable/src/control/control.c:125
    #3 0x7f8c5ce3cdf6 in g_simple_async_result_complete (/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0+0x74df6)
    #4 0x7f8c5ce3ce58 (/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0+0x74e58)
    #5 0x7f8c5c8a9b4c in g_main_context_dispatch (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x49b4c)
    #6 0x7f8c5c8a9f1f (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x49f1f)
    #7 0x7f8c5c8aa241 in g_main_loop_run (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4a241)
    #8 0x7f8c5e64bbf4 in gtk_main (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x1ebbf4)
    #9 0x7f8c5efe5384 in dt_gui_gtk_run /home/lebedevri/darktable/src/gui/gtk.c:964
    #10 0x400cf3 in main /home/lebedevri/darktable/src/main.c:25
    #11 0x7f8c57691b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #12 0x400bd8 (/usr/local/bin/darktable+0x400bd8)
LebedevRI added a commit that referenced this pull request May 23, 2015
@LebedevRI
picasa_api_destroy(): do call curl_easy_cleanup()
dd03329 
I see no segfault, not in picasa.c nor in facebook.c, so it must have been fixed already.

Fixes following LeakSanitizer-detected leak:
Direct leak of 36032 byte(s) in 1 object(s) allocated from:
    #0 0x7fe413b94895 in calloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54895)
    #1 0x7fe40f1b5319 (/usr/lib/x86_64-linux-gnu/libcurl-gnutls.so.4+0x1d319)
    #2 0x7fe40f1c4a03 in curl_easy_init (/usr/lib/x86_64-linux-gnu/libcurl-gnutls.so.4+0x2ca03)
    #3 0x7fe3ee78850b
    #4 0x7fe3ee78c10e
    #5 0x7fe4137589d3 in dt_imageio_load_modules_storage /home/lebedevri/darktable/src/common/imageio_module.c:306
    #6 0x7fe413758b05 in dt_imageio_init /home/lebedevri/darktable/src/common/imageio_module.c:321
    #7 0x7fe4136fe91f in dt_init /home/lebedevri/darktable/src/common/darktable.c:875
    #8 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #9 0x7fe40bf69b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #10 0x400bd8 (/usr/local/bin/darktable+0x400bd8)
LebedevRI added a commit that referenced this pull request May 23, 2015
@LebedevRI
dt_control_cleanup(): implement and call dt_control_jobs_cleanup()
8291a1e 
TODO(?): move some cleanup code into this new function?
Might help with current hang on quit if main window is not in focus.

Fixes following LeakSanitizer-detected leak:
Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x7f2cccb04895 in calloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54895)
    #1 0x7f2ccc712314 in dt_control_jobs_init /home/lebedevri/darktable/src/control/jobs.c:488
    #2 0x7f2ccc703b45 in dt_control_init /home/lebedevri/darktable/src/control/control.c:319
    #3 0x7f2ccc66e107 in dt_init /home/lebedevri/darktable/src/common/darktable.c:808
    #4 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #5 0x7f2cc4ed9b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
LebedevRI added a commit that referenced this pull request May 24, 2015
@LebedevRI
Bauhaus: fix some leaks related to autocompleteon lists
a7fc769 
Fixes a LOT of LeakSanitizer-detected leaks like:
Direct leak of 1298 byte(s) in 39 object(s) allocated from:
    #0 0x7f293d4d474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7f293aabf799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799)
    #2 0x7f293aad812e in g_strdup (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x6812e)
    #3 0x7f293d00f49a in dt_bauhaus_widget_set_label /home/lebedevri/darktable/src/bauhaus/bauhaus.c:849
    #4 0x7f293d15931b in dt_iop_gui_init_blending /home/lebedevri/darktable/src/develop/blend_gui.c:1797
    #5 0x7f293d10be91 in dt_iop_gui_get_expander /home/lebedevri/darktable/src/develop/imageop.c:1847
...
LebedevRI added a commit that referenced this pull request May 25, 2015
@LebedevRI
dt_opencl_cleanup(): free device name and cname
654b352 
Direct leak of 7 byte(s) in 1 object(s) allocated from:
    #0 0x7f51f2483327 in strdup (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x33327)
    #1 0x7f51f2072da1 in dt_opencl_init /home/lebedevri/darktable/src/common/opencl.c:317
    #2 0x7f51f1fcc605 in dt_init /home/lebedevri/darktable/src/common/darktable.c:839
    #3 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #4 0x7f51ea821b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)

Direct leak of 7 byte(s) in 1 object(s) allocated from:
    #0 0x7f51f24a474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7f51f2060618 in _ascii_str_canonical /home/lebedevri/darktable/src/common/opencl.c:858
    #2 0x7f51f2072e00 in dt_opencl_init /home/lebedevri/darktable/src/common/opencl.c:318
    #3 0x7f51f1fcc605 in dt_init /home/lebedevri/darktable/src/common/darktable.c:839
    #4 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #5 0x7f51ea821b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
LebedevRI added a commit that referenced this pull request May 27, 2015
@LebedevRI
Result of dt_loc_get_home_dir() should be g_free()'d at the end.
5b5477c 
Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x7f95987e474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7f9595d7f799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799)
    #2 0x7f9595d9812e in g_strdup (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x6812e)
    #3 0x7f95983365df in dt_loc_get_home_dir /home/lebedevri/darktable/src/common/file_location.c:41
    #4 0x7f95983988f7 in dt_util_fix_path /home/lebedevri/darktable/src/common/utility.c:198
    #5 0x7f95983364d1 in dt_loc_init_generic /home/lebedevri/darktable/src/common/file_location.c:84
    #6 0x7f9598336894 in dt_loc_init_user_cache_dir /home/lebedevri/darktable/src/common/file_location.c:161
    #7 0x7f959830a9da in dt_init /home/lebedevri/darktable/src/common/darktable.c:701
    #8 0x400dd3 in main /home/lebedevri/darktable/src/cltest/main.c:27
    #9 0x7f9590b61b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #190 0x400c68 in _start ??:?
LebedevRI added a commit that referenced this pull request May 27, 2015
@LebedevRI
dt_opencl_init(): results of dt_conf_get_string() should be g_free()'d
ed88970 
Direct leak of 11 byte(s) in 1 object(s) allocated from:
    #0 0x7f5b4e4f474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7f5b4ba8f799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799)
    #2 0x7f5b4baa812e in g_strdup (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x6812e)
    #3 0x7f5b4e0c4841 in dt_conf_get_string /home/lebedevri/darktable/src/control/conf.h:195
    #4 0x7f5b4e0c4841 in dt_opencl_init /home/lebedevri/darktable/src/common/opencl.c:524
    #5 0x7f5b4e01c6c5 in dt_init /home/lebedevri/darktable/src/common/darktable.c:839
    #6 0x400dd3 in main /home/lebedevri/darktable/src/cltest/main.c:27
    #7 0x7f5b46871b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #8 0x400c68 (/usr/local/bin/darktable-cltest+0x400c68)
LebedevRI added a commit that referenced this pull request May 27, 2015
@LebedevRI @pmjdebruijn
dt_ctl_set_display_profile(): free icc buffer we just got if profile …
ce09fdd 
…has not changed

Fixes following LeakSanitizer-detected leak:
Direct leak of 1548384 byte(s) in 3 object(s) allocated from:
    #0 0x7f913367474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7f9130c67799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799)
    #2 0x7f91325abb85 (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0+0x53b85)
    #3 0x7f9133274b15 in dt_ctl_set_display_profile /home/lebedevri/darktable/src/control/control.c:199
    #4 0x7f9133391d6e in window_configure /home/lebedevri/darktable/src/gui/gtk.c:625
    #5 0x7f9132a0531c (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x1ed31c)
    #6 0x7f9130f382d4 in g_closure_invoke (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x102d4)
    #7 0x7f9130f4a03b (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x2203b)
    #8 0x7f9130f521a4 in g_signal_emit_valist (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x2a1a4)
    #9 0x7f9130f528fe in g_signal_emit (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x2a8fe)
    #10 0x7f9132b35de3 (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x31dde3)
    #11 0x7f9132a04819 in gtk_main_do_event (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x1ec819)
    #12 0x7f91325a7b11 (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0+0x4fb11)
    #13 0x7f9130c61c3c in g_main_context_dispatch (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x49c3c)
    #14 0x7f9130c61f1f (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x49f1f)
    #15 0x7f9130c62241 in g_main_loop_run (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4a241)
    #16 0x7f9132a03bf4 in gtk_main (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x1ebbf4)
    #17 0x7f913339d36b in dt_gui_gtk_run /home/lebedevri/darktable/src/gui/gtk.c:964
    #18 0x400cf3 in main /home/lebedevri/darktable/src/main.c:25
    #19 0x7f912ba49b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #20 0x400bd8 (/usr/local/bin/darktable+0x400bd8)

(cherry picked from commit 5cf182b)
LebedevRI added a commit that referenced this pull request May 27, 2015
@LebedevRI @pmjdebruijn
dt_ctl_get_display_profile_colord_callback(): free icc buffer we just…
d19b095 
… got if profile has not changed

Fixes following LeakSanitizer-detected leak:
Direct leak of 516129 byte(s) in 1 object(s) allocated from:
    #0 0x7f8c5f2bc74f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7f8c5c8967cb in g_file_get_contents (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x367cb)
    #2 0x7f8c5eeb809a in dt_ctl_get_display_profile_colord_callback /home/lebedevri/darktable/src/control/control.c:125
    #3 0x7f8c5ce3cdf6 in g_simple_async_result_complete (/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0+0x74df6)
    #4 0x7f8c5ce3ce58 (/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0+0x74e58)
    #5 0x7f8c5c8a9b4c in g_main_context_dispatch (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x49b4c)
    #6 0x7f8c5c8a9f1f (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x49f1f)
    #7 0x7f8c5c8aa241 in g_main_loop_run (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4a241)
    #8 0x7f8c5e64bbf4 in gtk_main (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x1ebbf4)
    #9 0x7f8c5efe5384 in dt_gui_gtk_run /home/lebedevri/darktable/src/gui/gtk.c:964
    #10 0x400cf3 in main /home/lebedevri/darktable/src/main.c:25
    #11 0x7f8c57691b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #12 0x400bd8 (/usr/local/bin/darktable+0x400bd8)

(cherry picked from commit e9f50c3)
LebedevRI added a commit that referenced this pull request May 27, 2015
@LebedevRI @pmjdebruijn
picasa_api_destroy(): do call curl_easy_cleanup()
44bdd5e 
I see no segfault, not in picasa.c nor in facebook.c, so it must have been fixed already.

Fixes following LeakSanitizer-detected leak:
Direct leak of 36032 byte(s) in 1 object(s) allocated from:
    #0 0x7fe413b94895 in calloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54895)
    #1 0x7fe40f1b5319 (/usr/lib/x86_64-linux-gnu/libcurl-gnutls.so.4+0x1d319)
    #2 0x7fe40f1c4a03 in curl_easy_init (/usr/lib/x86_64-linux-gnu/libcurl-gnutls.so.4+0x2ca03)
    #3 0x7fe3ee78850b
    #4 0x7fe3ee78c10e
    #5 0x7fe4137589d3 in dt_imageio_load_modules_storage /home/lebedevri/darktable/src/common/imageio_module.c:306
    #6 0x7fe413758b05 in dt_imageio_init /home/lebedevri/darktable/src/common/imageio_module.c:321
    #7 0x7fe4136fe91f in dt_init /home/lebedevri/darktable/src/common/darktable.c:875
    #8 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #9 0x7fe40bf69b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #10 0x400bd8 (/usr/local/bin/darktable+0x400bd8)

(cherry picked from commit dd03329)
LebedevRI added a commit that referenced this pull request May 27, 2015
@LebedevRI @pmjdebruijn
dt_control_cleanup(): implement and call dt_control_jobs_cleanup()
791d382 
TODO(?): move some cleanup code into this new function?
Might help with current hang on quit if main window is not in focus.

Fixes following LeakSanitizer-detected leak:
Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x7f2cccb04895 in calloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54895)
    #1 0x7f2ccc712314 in dt_control_jobs_init /home/lebedevri/darktable/src/control/jobs.c:488
    #2 0x7f2ccc703b45 in dt_control_init /home/lebedevri/darktable/src/control/control.c:319
    #3 0x7f2ccc66e107 in dt_init /home/lebedevri/darktable/src/common/darktable.c:808
    #4 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #5 0x7f2cc4ed9b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)

(cherry picked from commit 8291a1e)
LebedevRI added a commit that referenced this pull request May 27, 2015
@LebedevRI @pmjdebruijn
Bauhaus: fix some leaks related to autocompleteon lists
b886564 
Fixes a LOT of LeakSanitizer-detected leaks like:
Direct leak of 1298 byte(s) in 39 object(s) allocated from:
    #0 0x7f293d4d474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7f293aabf799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799)
    #2 0x7f293aad812e in g_strdup (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x6812e)
    #3 0x7f293d00f49a in dt_bauhaus_widget_set_label /home/lebedevri/darktable/src/bauhaus/bauhaus.c:849
    #4 0x7f293d15931b in dt_iop_gui_init_blending /home/lebedevri/darktable/src/develop/blend_gui.c:1797
    #5 0x7f293d10be91 in dt_iop_gui_get_expander /home/lebedevri/darktable/src/develop/imageop.c:1847
...

(cherry picked from commit a7fc769)
LebedevRI added a commit that referenced this pull request May 27, 2015
@LebedevRI @pmjdebruijn
dt_opencl_cleanup(): free device name and cname
9389323 
Direct leak of 7 byte(s) in 1 object(s) allocated from:
    #0 0x7f51f2483327 in strdup (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x33327)
    #1 0x7f51f2072da1 in dt_opencl_init /home/lebedevri/darktable/src/common/opencl.c:317
    #2 0x7f51f1fcc605 in dt_init /home/lebedevri/darktable/src/common/darktable.c:839
    #3 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #4 0x7f51ea821b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)

Direct leak of 7 byte(s) in 1 object(s) allocated from:
    #0 0x7f51f24a474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7f51f2060618 in _ascii_str_canonical /home/lebedevri/darktable/src/common/opencl.c:858
    #2 0x7f51f2072e00 in dt_opencl_init /home/lebedevri/darktable/src/common/opencl.c:318
    #3 0x7f51f1fcc605 in dt_init /home/lebedevri/darktable/src/common/darktable.c:839
    #4 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24
    #5 0x7f51ea821b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)

(cherry picked from commit 654b352)
LebedevRI added a commit that referenced this pull request May 27, 2015
@LebedevRI @pmjdebruijn
Result of dt_loc_get_home_dir() should be g_free()'d at the end.
8d6faca 
Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x7f95987e474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7f9595d7f799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799)
    #2 0x7f9595d9812e in g_strdup (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x6812e)
    #3 0x7f95983365df in dt_loc_get_home_dir /home/lebedevri/darktable/src/common/file_location.c:41
    #4 0x7f95983988f7 in dt_util_fix_path /home/lebedevri/darktable/src/common/utility.c:198
    #5 0x7f95983364d1 in dt_loc_init_generic /home/lebedevri/darktable/src/common/file_location.c:84
    #6 0x7f9598336894 in dt_loc_init_user_cache_dir /home/lebedevri/darktable/src/common/file_location.c:161
    #7 0x7f959830a9da in dt_init /home/lebedevri/darktable/src/common/darktable.c:701
    #8 0x400dd3 in main /home/lebedevri/darktable/src/cltest/main.c:27
    #9 0x7f9590b61b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #190 0x400c68 in _start ??:?

(cherry picked from commit 5b5477c)
LebedevRI added a commit that referenced this pull request May 27, 2015
@LebedevRI @pmjdebruijn
dt_opencl_init(): results of dt_conf_get_string() should be g_free()'d
caa823c 
Direct leak of 11 byte(s) in 1 object(s) allocated from:
    #0 0x7f5b4e4f474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f)
    #1 0x7f5b4ba8f799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799)
    #2 0x7f5b4baa812e in g_strdup (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x6812e)
    #3 0x7f5b4e0c4841 in dt_conf_get_string /home/lebedevri/darktable/src/control/conf.h:195
    #4 0x7f5b4e0c4841 in dt_opencl_init /home/lebedevri/darktable/src/common/opencl.c:524
    #5 0x7f5b4e01c6c5 in dt_init /home/lebedevri/darktable/src/common/darktable.c:839
    #6 0x400dd3 in main /home/lebedevri/darktable/src/cltest/main.c:27
    #7 0x7f5b46871b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
    #8 0x400c68 (/usr/local/bin/darktable-cltest+0x400c68)

(cherry picked from commit ed88970)
LebedevRI added a commit that referenced this pull request Oct 1, 2015
@LebedevRI @pmjdebruijn
Mask removal: dt_masks_form_remove() after dt_dev_masks_list_remove()
5152a28 
Fixes: AddressSanitizer: heap-use-after-free on address 0x60e00013d4b4 at pc 0x7fd6409390f3 bp 0x7ffdd90547c0 sp 0x7ffdd90547b8
READ of size 4 at 0x60e00013d4b4 thread T0
    #0 0x7fd6409390f2 in dt_ellipse_events_button_released /home/lebedevri/darktable/src/develop/masks/ellipse.c:434
    #1 0x7fd64093a8f1 in dt_group_events_button_released /home/lebedevri/darktable/src/develop/masks/group.c:115
    #2 0x7fd64093a8f1 in dt_masks_events_button_released /home/lebedevri/darktable/src/develop/masks/masks.c:1199
    #3 0x7fd61b64495c in button_released /home/lebedevri/darktable/src/views/darkroom.c:1882
    #4 0x7fd6409ad45e in dt_view_manager_button_released /home/lebedevri/darktable/src/views/view.c:569
    #5 0x7fd64096918c in button_released /home/lebedevri/darktable/src/gui/gtk.c:665
...

0x60e00013d4b4 is located 148 bytes inside of 160-byte region [0x60e00013d420,0x60e00013d4c0)
freed by thread T0 here:
    #0 0x7fd640c890da in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x940da)
    #1 0x7fd640935982 in dt_masks_form_remove /home/lebedevri/darktable/src/develop/masks/masks.c:1854
    #2 0x7fd6409390c5 in dt_ellipse_events_button_released /home/lebedevri/darktable/src/develop/masks/ellipse.c:433
    #3 0x7fd64093a8f1 in dt_group_events_button_released /home/lebedevri/darktable/src/develop/masks/group.c:115
    #4 0x7fd64093a8f1 in dt_masks_events_button_released /home/lebedevri/darktable/src/develop/masks/masks.c:1199
    #5 0x7fd61b64495c in button_released /home/lebedevri/darktable/src/views/darkroom.c:1882
    #6 0x7fd6409ad45e in dt_view_manager_button_released /home/lebedevri/darktable/src/views/view.c:569
    #7 0x7fd64096918c in button_released /home/lebedevri/darktable/src/gui/gtk.c:665
    #8 0x7fd63ffb5a8c  (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x208a8c)

previously allocated by thread T0 here:
    #0 0x7fd640c8937a in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x9437a)
    #1 0x7fd640915ce3 in dt_masks_create /home/lebedevri/darktable/src/develop/masks/masks.c:777
    #2 0x7fd61af68c61 in _add_ellipse /home/lebedevri/darktable/src/iop/spots.c:211
    #3 0x7fd63ffb5a8c  (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x208a8c)

SUMMARY: AddressSanitizer: heap-use-after-free /home/lebedevri/darktable/src/develop/masks/ellipse.c:434 dt_ellipse_events_button_released
(cherry picked from commit f6de34b)
@LebedevRI LebedevRI modified the milestone: 1.1.x Oct 15, 2016
cryptomilk added a commit to cryptomilk/darktable that referenced this pull request Nov 24, 2019
@cryptomilk
colorspaces: Fix an invalid memmove() with littlecms
d01a6c5 
READ of size 24 at 0x7fffffffa2b8 thread T0
    #0 0x7ffff761162d in memmove (/usr/lib64/libasan.so.5+0x9f62d)
    #1 0x7ffff4a72a46 in memmove /usr/include/bits/string_fortified.h:40
    darktable-org#2 0x7ffff4a72a46 in _cmsDupDefaultFn /usr/src/debug/lcms2-2.9-2.5.x86_64/src/cmserr.c:174
    darktable-org#3 0x7ffff4a6efba in cmsWriteTag /usr/src/debug/lcms2-2.9-2.5.x86_64/src/cmsio0.c:1733
    darktable-org#4 0x7ffff4a6efba in cmsWriteTag /usr/src/debug/lcms2-2.9-2.5.x86_64/src/cmsio0.c:1639
    darktable-org#5 0x7ffff6c18c06 in _create_lcms_profile /home/asn/workspace/projects/darktable/src/common/colorspaces.c:299
    darktable-org#6 0x7ffff6c1900b in _colorspaces_create_srgb_profile /home/asn/workspace/projects/darktable/src/common/colorspaces.c:330
    darktable-org#7 0x7ffff6c1908e in dt_colorspaces_create_srgb_profile /home/asn/workspace/projects/darktable/src/common/colorspaces.c:340
    darktable-org#8 0x7ffff6c221f5 in dt_colorspaces_init /home/asn/workspace/projects/darktable/src/common/colorspaces.c:1270
    darktable-org#9 0x7ffff6c34a5a in dt_init /home/asn/workspace/projects/darktable/src/common/darktable.c:821
    darktable-org#10 0x4009be in main /home/asn/workspace/projects/darktable/src/main.c:92
    darktable-org#11 0x7ffff67bee0a in __libc_start_main (/lib64/libc.so.6+0x26e0a)
    darktable-org#12 0x4008e9 in _start (/home/asn/workspace/projects/darktable/obj-asan/src/darktable+0x4008e9)
cryptomilk added a commit to cryptomilk/darktable that referenced this pull request Nov 24, 2019
@cryptomilk
colorspaces: Fix an invalid memmove() with littlecms
4c924df 
READ of size 24 at 0x7fffffffa2b8 thread T0
    #0 0x7ffff761162d in memmove (/usr/lib64/libasan.so.5+0x9f62d)
    #1 0x7ffff4a72a46 in memmove /usr/include/bits/string_fortified.h:40
    darktable-org#2 0x7ffff4a72a46 in _cmsDupDefaultFn /usr/src/debug/lcms2-2.9-2.5.x86_64/src/cmserr.c:174
    darktable-org#3 0x7ffff4a6efba in cmsWriteTag /usr/src/debug/lcms2-2.9-2.5.x86_64/src/cmsio0.c:1733
    darktable-org#4 0x7ffff4a6efba in cmsWriteTag /usr/src/debug/lcms2-2.9-2.5.x86_64/src/cmsio0.c:1639
    darktable-org#5 0x7ffff6c18c06 in _create_lcms_profile /home/asn/workspace/projects/darktable/src/common/colorspaces.c:299
    darktable-org#6 0x7ffff6c1900b in _colorspaces_create_srgb_profile /home/asn/workspace/projects/darktable/src/common/colorspaces.c:330
    darktable-org#7 0x7ffff6c1908e in dt_colorspaces_create_srgb_profile /home/asn/workspace/projects/darktable/src/common/colorspaces.c:340
    darktable-org#8 0x7ffff6c221f5 in dt_colorspaces_init /home/asn/workspace/projects/darktable/src/common/colorspaces.c:1270
    darktable-org#9 0x7ffff6c34a5a in dt_init /home/asn/workspace/projects/darktable/src/common/darktable.c:821
    darktable-org#10 0x4009be in main /home/asn/workspace/projects/darktable/src/main.c:92
    darktable-org#11 0x7ffff67bee0a in __libc_start_main (/lib64/libc.so.6+0x26e0a)
    darktable-org#12 0x4008e9 in _start (/home/asn/workspace/projects/darktable/obj-asan/src/darktable+0x4008e9)

(cherry picked from commit 3337ac2d18588a89580a8685f49afb5918cc1d30)
cryptomilk added a commit to cryptomilk/darktable that referenced this pull request Nov 24, 2019
@cryptomilk
colorspaces: Fix an invalid memmove() with littlecms
5cd481f 
READ of size 24 at 0x7fffffffa2b8 thread T0
    #0 0x7ffff761162d in memmove (/usr/lib64/libasan.so.5+0x9f62d)
    #1 0x7ffff4a72a46 in memmove /usr/include/bits/string_fortified.h:40
    darktable-org#2 0x7ffff4a72a46 in _cmsDupDefaultFn /usr/src/debug/lcms2-2.9-2.5.x86_64/src/cmserr.c:174
    darktable-org#3 0x7ffff4a6efba in cmsWriteTag /usr/src/debug/lcms2-2.9-2.5.x86_64/src/cmsio0.c:1733
    darktable-org#4 0x7ffff4a6efba in cmsWriteTag /usr/src/debug/lcms2-2.9-2.5.x86_64/src/cmsio0.c:1639
    darktable-org#5 0x7ffff6c18c06 in _create_lcms_profile /home/asn/workspace/projects/darktable/src/common/colorspaces.c:299
    darktable-org#6 0x7ffff6c1900b in _colorspaces_create_srgb_profile /home/asn/workspace/projects/darktable/src/common/colorspaces.c:330
    darktable-org#7 0x7ffff6c1908e in dt_colorspaces_create_srgb_profile /home/asn/workspace/projects/darktable/src/common/colorspaces.c:340
    darktable-org#8 0x7ffff6c221f5 in dt_colorspaces_init /home/asn/workspace/projects/darktable/src/common/colorspaces.c:1270
    darktable-org#9 0x7ffff6c34a5a in dt_init /home/asn/workspace/projects/darktable/src/common/darktable.c:821
    darktable-org#10 0x4009be in main /home/asn/workspace/projects/darktable/src/main.c:92
    darktable-org#11 0x7ffff67bee0a in __libc_start_main (/lib64/libc.so.6+0x26e0a)
    darktable-org#12 0x4008e9 in _start (/home/asn/workspace/projects/darktable/obj-asan/src/darktable+0x4008e9)
@RonnyB74 RonnyB74 mentioned this pull request May 25, 2020
Closed
@bigntallmike bigntallmike mentioned this pull request Jul 3, 2020
Closed
@cponce cponce mentioned this pull request Aug 3, 2020
Closed
@cryptomilk cryptomilk mentioned this pull request Aug 30, 2020
Closed
@aurelienpierre aurelienpierre mentioned this pull request Nov 29, 2020
Closed
@dterrahe dterrahe mentioned this pull request Dec 2, 2020
Merged
@GLLM GLLM mentioned this pull request Dec 23, 2020
Closed
@UsefGeorge UsefGeorge mentioned this pull request Mar 18, 2021
Closed
@piratenpanda piratenpanda mentioned this pull request May 19, 2021
Closed
@payano payano mentioned this pull request Oct 7, 2021
Closed
@alexvanderberkel alexvanderberkel mentioned this pull request Nov 9, 2021
Closed
@difrkaguilar difrkaguilar mentioned this pull request Nov 24, 2021
Closed
@andabata andabata mentioned this pull request Dec 2, 2021
Closed
@talmholt talmholt mentioned this pull request Apr 12, 2022
Closed
@pehar1 pehar1 mentioned this pull request May 3, 2022
Closed
Sturmflut pushed a commit to Sturmflut/darktable that referenced this pull request Sep 1, 2022
@matze
Fix darktable-org#5: use lensfun repo for up-to-date lenses
0474701
@M-K-G M-K-G mentioned this pull request Nov 12, 2023
Closed
@kofa73 kofa73 mentioned this pull request Sep 4, 2024
Closed
@quovadit quovadit mentioned this pull request Oct 20, 2024
Open
@scorpi11 scorpi11 mentioned this pull request Nov 18, 2024
Closed
@Cartoon-Dude Cartoon-Dude mentioned this pull request Jan 12, 2025
Closed
@cycomanic cycomanic mentioned this pull request Feb 2, 2025
Closed
1 task
@jstes jstes mentioned this pull request Feb 10, 2025
Closed
1 task
@AndDiSa AndDiSa mentioned this pull request Oct 20, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@madanyang @LebedevRI @upegelow