dt crashes when ctrl+click on feathering line in drawn-mask #15622
Description
Describe the bug
darktable (dt) crashes when I ctrl-left-click (accidentally or intentionally) on the dotted feathering line of a (drawn) path mask. This is the case both in 'drawn-mask mode' and in 'drawn+parametric-mask mode'. This happens when I edit RAW files.
I had the first crashes without realizing what's going on: Often a mask's solid line and dotted line are closely together. Trying to add a note to the mask you're bound to hit the wrong line at some point.
I realized what the problem is when I intuitively and without thinking wanted to add a note just to the dotted line which was at a larger distance from its solid counterpart. Dt crashed. I've been able to reliably reproduce this crashing behavior multiple times (also with other images from other collections).
For completeness' sake: The bug doesn't (seem to) affect any other drawn masks. Which makes sense since none of the other masks have (i) "grabable notes" and (ii) the option to add notes.
The bug does not seem to be restricted to any particular modules. I successfully confirmed the crashing behavior in Exposure and Color Zones.
dt 4.4.2
MacOS Ventura 13.5.2
MacbBook Pro - 3.1 GHz, i7, 16GB
Steps to reproduce
- Pick any module that includes drawn masks.
- Pick the path tool and draw a path mask in your photo.
- Shift+scroll to increase feathering such that the solid and dashed lines are clearly separated.
- On the solid line, ctrl+click between two notes in order to add a segment. This should work just fine.
- On the dotted line, ctrl+click between two notes. This is where dt crashes for me.
Expected behavior
Either a.) do nothing or b.) add a (grabable) note to the dotted feathering line.
Logfile | Screenshot | Screencast
23.11.11.-crash_drawmask_feather.txt
Commit
No response
Where did you install darktable from?
darktable.org
darktable version
4.4.2
What OS are you using?
Mac
What is the version of your OS?
MacOS Ventura 13.5.2
Describe your system?
It's MacbBook Pro - 3.1 GHz QuadCore Intel i7,
16 GB 2133 MHz LPDDR3
Intel HD Graphics 630 1536 MB
Are you using OpenCL GPU in darktable?
I dont know
If yes, what is the GPU card and driver?
No response
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
- I have not tried other versions of darktable.
- Happens with both JPG and RAW.
- Happens also with fresh edits.
- No Lua used.