Accels: free user_data in preset_iop_module_callback_destroyer()

LebedevRI · LebedevRI · commit 096731fa3eb2 · 2015-05-23T14:03:11.000+03:00
That was allocated in dt_accel_connect_preset_iop() Fixes following LeakSanitizer-detected leak: Direct leak of 1616 byte(s) in 101 object(s) allocated from: #0 0x7fe9ab77474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f) #1 0x7fe9a8d67799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799) #2 0x7fe9ab3afe5d in dt_iop_connect_common_accels /home/lebedevri/darktable/src/develop/imageop.c:2784 #3 0x7fe9874ec398 #4 0x7fe9ab4ebf54 in dt_view_manager_switch /home/lebedevri/darktable/src/views/view.c:401 #5 0x7fe9ab370506 in _dt_ctl_switch_mode_to /home/lebedevri/darktable/src/control/control.c:630 #6 0x7fe9a8d62be4 in g_main_context_invoke_full (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4abe4)
diff --git a/src/gui/accelerators.c b/src/gui/accelerators.c
@@ -533,6 +533,7 @@ static void preset_iop_module_callback_destroyer(gpointer data, GClosure *closur
   preset_iop_module_callback_description *callback_description
       = (preset_iop_module_callback_description *)data;
   g_free(callback_description->name);
+  g_free(data);
 }
 static gboolean preset_iop_module_callback(GtkAccelGroup *accel_group, GObject *acceleratable, guint keyval,
                                            GdkModifierType modifier, gpointer data)

Original file line number	Diff line number	Diff line change
`@@ -533,6 +533,7 @@ static void preset_iop_module_callback_destroyer(gpointer data, GClosure *closur`
`533`	`533`	`preset_iop_module_callback_description *callback_description`
`534`	`534`	`= (preset_iop_module_callback_description *)data;`
`535`	`535`	`g_free(callback_description->name);`
	`536`	`+ g_free(data);`
`536`	`537`	`}`
`537`	`538`	`static gboolean preset_iop_module_callback(GtkAccelGroup accel_group, GObject acceleratable, guint keyval,`
`538`	`539`	`GdkModifierType modifier, gpointer data)`