Feature #8758 - enable/disable overwriting files during disk export

[itarozzi]

• Add checkbutton in disk export module
• Add new option in gui tab preference

Notes:

1. todo-> update checkbutton when exit option dialog
2. choose if reset to default (option value) the checkbutton value after image export

[boucman]

it's a bit early for a pull-request on that, you still have debug printf in your code and there are important TODO that needs to be filled

on another note, we have been discussing this issue on IRC a bit and we don't have a consensus on adding that checkbox...

We do agree on the problem of overwriting, but we are looking for a better UI solution than the checkbox. We will post on the ML thread once we are a bit more consistent on our opinion

In the mean time I will close this merge request, feel free to rerequest once it is more mature

[itarozzi]

Il 06/06/2012 10:48, Boucman ha scritto:

it's a bit early for a pull-request on that, you still have debug printf in your code and there are important TODO that needs to be filled

Sorry Boucman,
I'm newbie on github and I didn't understand pull-request use; I didn't
want to use it as request to merge but only as commit notification to
main team. My mistake!

on another note, we have been discussing this issue on IRC a bit and we don't have a consensus on adding that checkbox...

Ok, no problem, but I had no feedback about this and I started to add it
because in my workflow will be useful and because to learn something
about DT code and gtk :)

We do agree on the problem of overwriting, but we are looking for a better UI solution than the checkbox. We will post on the ML thread once we are a bit more consistent on our opinion

Ok, no problem. I agree there could be a better solution.

In the mean time I will close this merge request, feel free to rerequest once it is more mature

Of course!
but you think could have sense to complete my branch or is better stop
working waiting a better solution you ask above?
If dev-team will never accept this patch because there is not consensus,
may be I will spend my time over other issue or features.

Thank you and sorry for entropy :)

Ivan

[boucman]

Sorry Boucman,
I'm newbie on github and I didn't understand pull-request use; I didn't
want to use it as request to merge but only as commit notification to
main team. My mistake!

no problem, we are all learning...

we can see what other people are doing on wesnoth using

https://github.com/darktable-org/darktable/network

on another note, we have been discussing this issue on IRC a bit and we don't have a consensus on adding that checkbox...

Ok, no problem, but I had no feedback about this and I started to add it
because in my workflow will be useful and because to learn something
about DT code and gtk :)

yes, these are good reasons and we havn't been good at voicing our
opinion on that particular debate...

We do agree on the problem of overwriting, but we are looking for a better UI solution than the checkbox. We will post on the ML thread once we are a bit more consistent on our opinion

Ok, no problem. I agree there could be a better solution.

In the mean time I will close this merge request, feel free to rerequest once it is more mature

Of course!
but you think could have sense to complete my branch or is better stop
working waiting a better solution you ask above?

there are all sorts of small feature requests in redmine that could be
good learning tasks... marie-noëlle's recent UI request comes to mind
but is certainly not the only one... feel free to work on any of
these, it might be more usefull than that particular feature.

If dev-team will never accept this patch because there is not consensus,
may be I will spend my time over other issue or features.

Thank you and sorry for entropy :)

no prob, the only way to avoid entropy is to not do anything... which
is worse...

Ivan

---

Reply to this email directly or view it on GitHub:
#12 (comment)