-
Notifications
You must be signed in to change notification settings - Fork 3k
Bump minimum Go version to 1.24.0 #41968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Requires #41966 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the minimum supported Go version from 1.23.0 to 1.24.0 across the OpenTelemetry Collector Contrib repository, aligning with the upstream collector's Go version update policy as Go 1.25.0 has been released.
Key changes:
- Update
go
directive in all go.mod files from1.23.0
to1.24
- Replace
context.Background()
calls in test files witht.Context()
to utilize testing context - Remove unnecessary
context
package imports where they're no longer needed after context replacement
Reviewed Changes
Copilot reviewed 300 out of 1244 changed files in this pull request and generated 9 comments.
File | Description |
---|---|
*/go.mod | Updated Go version directive from 1.23.0 to 1.24 |
*_test.go | Replaced context.Background() with t.Context() and removed unused context imports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
The govulncheck errors are also on main, I don't think we should try to fix them in this PR - it's already a bit extreme as it is. |
Notable upgrade, this also bumps minimum Go version from `1.23.0` to `1.24`, see: - [collector #13627](open-telemetry/opentelemetry-collector#13627) - [collector-contrib #41968](open-telemetry/opentelemetry-collector-contrib#41968). (Also updated CHANGELOG for a few recent changes)
Notable upgrade, this also bumps minimum Go version from `1.23.0` to `1.24`, see: - [collector #13627](open-telemetry/opentelemetry-collector#13627) - [collector-contrib #41968](open-telemetry/opentelemetry-collector-contrib#41968). (Also updated CHANGELOG for a few recent changes)
## Release v0.42.0 This PR prepares the repository for release v0.42.0. ### Changes included: - Updated CHANGELOG.md with release notes - Updated collector/otelarrowcol-build.yaml version to v0.42.0 - Updated collector/cmd/otelarrowcol/main.go version to v0.42.0 ### Release Notes: - Standardize to shorthand license header. [#954](#954) - Fix logs handling of missing optional trace_id and span_id columns. [#973](#973) - Upgrade to v0.133.0 / v1.37.0 of collector dependencies. [#890](#890), [#1010](#1010) - Notable upgrade, this also bumps minimum Go version from `1.23.0` to `1.24`, see [collector #13627](open-telemetry/opentelemetry-collector#13627) and [collector-contrib #41968](open-telemetry/opentelemetry-collector-contrib#41968). ### Checklist: - [x] Verify CHANGELOG.md formatting and content - [x] Verify collector version update in collector/otelarrowcol-build.yaml - [x] Verify collector main.go version update in collector/cmd/otelarrowcol/main.go - [x] Confirm all tests pass - [x] Ready to merge and tag release After merging this PR, run the **Push Release** workflow to create git tags and publish the GitHub release. Co-authored-by: otelbot <[email protected]>
…e process (#1019) When using the `Prepare Release` and `Push Release` actions the extracted Changelog content displays incorrectly. The repo lint enforces line length in markdown files, leading to extra newlines in raw content: ```md - Upgrade to v0.133.0 / v1.37.0 of collector dependencies. [#890](#890), [#1010](#1010) - Notable upgrade, this also bumps minimum Go version from `1.23.0` to `1.24`, see [collector #13627](open-telemetry/opentelemetry-collector#13627) and [collector-contrib #41968](open-telemetry/opentelemetry-collector-contrib#41968). ``` When viewing the [Changelog itself](https://github.com/open-telemetry/otel-arrow/blob/main/CHANGELOG.md) GitHub renders this in proper way. However, when we extract it to embed in a PR body (in `Prepare Release`) or in a Release object (in `Push Release`) the rendering is not the same: <img width="1078" height="539" alt="image" src="https://github.com/user-attachments/assets/9eb14da1-4754-4a2c-962b-7bde9267bcba" /> The script now normalizes whitespace in the extracted content to display properly in the specific use cases we have: <img width="2045" height="417" alt="image" src="https://github.com/user-attachments/assets/ca07579e-ca69-4ef3-8954-902a6f0c2852" /> Small improvement but saves 2 seconds of manual tweaking during each release 😄
Description
Go 1.25.0 is released, time to bump the minimum supported version.
See also open-telemetry/opentelemetry-collector#13627
Link to tracking issue
Fixes #38970
Testing
N/A
Documentation
Updated