-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(deps): update module github.com/jaegertracing/jaeger-idl to v0.6.0 #41315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update module github.com/jaegertracing/jaeger-idl to v0.6.0 #41315
Conversation
pkg/translator/jaeger/go.mod
Outdated
@@ -1,10 +1,10 @@ | |||
module github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/jaeger | |||
|
|||
go 1.23.0 | |||
go 1.23.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want the go version bump yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the problem with patch version bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just means we drop support for <go 1.23.5 and will force all the downstream packages to do so (e.g. zipkin packages in this PR). That is not ideal so we've been trying to avoid it.
cc @mx-psi if you have more thoughts on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's pretty much it, we document we support the last two minor Go versions so if we want to change this we would have to change that 'compatibility' section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok but in cmd/opampsupervisor/go.mod I see 1.23.7 already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The policy applies "when used as library", artifacts under cmd/
are not (and cannot) be used as a library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#41968 bumps to 1.24, we can probably revive this PR now
4d08241
to
3a7e069
Compare
3a7e069
to
bdd9fac
Compare
fc6844f
to
ef43b35
Compare
95cc2be
to
e118483
Compare
This PR contains the following updates:
v0.5.0
->v0.6.0
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
jaegertracing/jaeger-idl (github.com/jaegertracing/jaeger-idl)
v0.6.0
Compare Source
What's Changed
query_service.proto
by @mahadzaryab1 in https://github.com/jaegertracing/jaeger-idl/pull/149jaeger
tojaeger-idl
by @mahadzaryab1 in https://github.com/jaegertracing/jaeger-idl/pull/168New Contributors
Full Changelog: jaegertracing/jaeger-idl@v0.5.0...v0.6.0
Configuration
📅 Schedule: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.