[chore] asapauthextension: fix tests under Go 1.24 #41966
Merged
+31
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under Go 1.24, use of RSA keys with fewer than
1024 bits leads to an error. This causes the tests
to fail like so:
```
=== RUN TestRoundTripper
extension_test.go:58:
Error Trace:
/home/andrew/projects/opentelemetry-collector-contrib/extension/asapauthextension/extension_test.go:58
Error: Received unexpected error:
crypto/rsa: 512-bit keys are insecure
(see https://go.dev/pkg/crypto/rsa#hdr-Minimum_key_size)
Test: TestRoundTripper
--- FAIL: TestRoundTripper (0.00s)
```
MovieStoreGuy
approved these changes
Aug 13, 2025
|
govulncheck is quite unhappy with the repo, but none of the extension issues are related to asapauthextension: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/16927008529/job/47964816560?pr=41966 |
bogdandrutu
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Under Go 1.24, use of RSA keys with fewer than 1024 bits leads to an error. This causes the tests to fail like so:
Rather than using a hard-coded key pair, we can use httptest's internal testing key pair which can be relied on to always be valid.
Link to tracking issue
open-telemetry/opentelemetry-collector#13627
Testing
N/A
Documentation
N/A