perf: introduce completePromisedListItemValue #4051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
This was referenced Apr 7, 2024
|
|
yaacovCR
added
the
PR: polish 💅
|
avoids an unnecessary .then() |
yaacovCR
force-pushed
the
complete-promised-list-item-value
branch
3 times, most recently
from
3e963af to
d171b67
Compare
yaacovCR
added a commit
that referenced
this pull request
Apr 18, 2024
following graphql/graphql-spec#1077 now part of the following PR stack, with the laters PRs extracted from this one #4026: incremental: introduce GraphQLWrappedResult to avoid filtering #4050: perf: allow skipping of field plan generation #4051: perf: introduce completePromisedListItemValue #4052: refactor: introduce completeIterableValue #4053: perf: optimize completion loops #4046: perf: use undefined for empty
yaacovCR
force-pushed
the
complete-promised-list-item-value
branch
from
d171b67 to
edded84
Compare
yaacovCR
force-pushed
the
complete-promised-list-item-value
branch
from
edded84 to
cf4d620
Compare
robrichard
approved these changes
Apr 22, 2024
saihaj
approved these changes
Apr 23, 2024
yaacovCR
added a commit
that referenced
this pull request
Apr 24, 2024
refactoring that will streamline when we introduce two versions of this function to optimize the loop when not streaming depends on #4051
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #4050