Skip to content

perf: introduce completePromisedListItemValue #4051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2024
Merged

perf: introduce completePromisedListItemValue #4051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 43 additions & 12 deletions src/execution/execute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,19 +1107,17 @@ async function completeAsyncIteratorValue(
/* c8 ignore start */
if (isPromise(item)) {
completedResults.push(
completePromisedValue(
completePromisedListItemValue(
item,
graphqlWrappedResult,
exeContext,
itemType,
fieldGroup,
info,
itemPath,
item,
incrementalContext,
deferMap,
).then((resolved) => {
graphqlWrappedResult[1].push(...resolved[1]);
return resolved[0];
}),
),
);
containsPromise = true;
} else if (
Expand Down Expand Up @@ -1232,19 +1230,17 @@ function completeListValue(

if (isPromise(item)) {
completedResults.push(
completePromisedValue(
completePromisedListItemValue(
item,
graphqlWrappedResult,
exeContext,
itemType,
fieldGroup,
info,
itemPath,
item,
incrementalContext,
deferMap,
).then((resolved) => {
graphqlWrappedResult[1].push(...resolved[1]);
return resolved[0];
}),
),
);
containsPromise = true;
} else if (
Expand Down Expand Up @@ -1334,6 +1330,41 @@ function completeListItemValue(
return false;
}

async function completePromisedListItemValue(
item: unknown,
parent: GraphQLWrappedResult<Array<unknown>>,
exeContext: ExecutionContext,
itemType: GraphQLOutputType,
fieldGroup: FieldGroup,
info: GraphQLResolveInfo,
itemPath: Path,
incrementalContext: IncrementalContext | undefined,
deferMap: ReadonlyMap<DeferUsage, DeferredFragmentRecord> | undefined,
): Promise<unknown> {
try {
const resolved = await item;
let completed = completeValue(
exeContext,
itemType,
fieldGroup,
info,
itemPath,
resolved,
incrementalContext,
deferMap,
);
if (isPromise(completed)) {
completed = await completed;
}
parent[1].push(...completed[1]);
return completed[0];
} catch (rawError) {
const errors = (incrementalContext ?? exeContext).errors;
handleFieldError(rawError, itemType, fieldGroup, itemPath, errors);
return null;
}
}

/**
* Complete a Scalar or Enum by serializing to a valid value, returning
* null if serialization is not possible.
Expand Down