Skip to content

Conversation

@yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Apr 7, 2024

in the non-deferred case.

depends on #4026

@yaacovCR yaacovCR requested review from a team and robrichard April 7, 2024 10:03
@netlify
Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 21e3a3c
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/66225f4b378d6900087b958b
😎 Deploy Preview https://deploy-preview-4050--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Apr 7, 2024

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR
Copy link
Contributor Author

yaacovCR commented Apr 7, 2024

image

@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Apr 7, 2024
@yaacovCR yaacovCR force-pushed the allow-skip branch 2 times, most recently from dbb24f8 to 7f05ab8 Compare April 7, 2024 13:12
yaacovCR added a commit that referenced this pull request Apr 18, 2024
following graphql/graphql-spec#1077

now part of the following PR stack, with the laters PRs extracted from
this one

#4026: incremental: introduce GraphQLWrappedResult to avoid filtering
#4050: perf: allow skipping of field plan generation
#4051: perf: introduce completePromisedListItemValue
#4052: refactor: introduce completeIterableValue
#4053: perf: optimize completion loops
#4046: perf: use undefined for empty
@yaacovCR yaacovCR merged commit 6d777e6 into graphql:main Apr 19, 2024
@yaacovCR yaacovCR deleted the allow-skip branch April 19, 2024 14:05
yaacovCR added a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: polish 💅 PR doesn't change public API or any observed behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants