-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19343: Add native support for GCS connector #7869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
🎊 +1 overall
This message was automatically generated. |
hadoop-tools/hadoop-gcp/pom.xml
Outdated
<scope>test</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>junit</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove the JUnit4 dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point! I sent up #7872 for this.
hadoop-project/pom.xml
Outdated
@@ -108,7 +108,7 @@ | |||
<findbugs.version>3.0.5</findbugs.version> | |||
<dnsjava.version>3.6.1</dnsjava.version> | |||
|
|||
<guava.version>27.0-jre</guava.version> | |||
<guava.version>33.1.0-jre</guava.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we update the version of the JAR package, the LICENSE-binary file should also be updated accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Searching import com.google.common
returns no results, just wondering how upgrading Guava is related to this PR?
No offense, but given that there were many painful experiences with Guava for Hadoop ecosystem projects, I think we'd better be careful to introduce new components that hardly depend on Guava, especially one that requires a specific version of Guava.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guava is a dependency of the GCS SDK. Without this change, there is a dependency convergence problem:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (depcheck) on project hadoop-gcp:
[ERROR] Rule 0: org.apache.maven.enforcer.rules.dependency.DependencyConvergence failed with message:
[ERROR] Failed while enforcing releasability.
[ERROR]
[ERROR] Dependency convergence error for org.codehaus.mojo:animal-sniffer-annotations:jar:1.17 paths to dependency are:
[ERROR] +-org.apache.hadoop:hadoop-gcp:jar:3.5.0-SNAPSHOT
[ERROR] +-com.google.cloud:google-cloud-storage:jar:2.52.0:compile
[ERROR] +-com.google.guava:guava:jar:27.0-jre:compile
[ERROR] +-org.codehaus.mojo:animal-sniffer-annotations:jar:1.17:compile
[ERROR] and
[ERROR] +-org.apache.hadoop:hadoop-gcp:jar:3.5.0-SNAPSHOT
[ERROR] +-com.google.cloud:google-cloud-storage:jar:2.52.0:compile
[ERROR] +-org.codehaus.mojo:animal-sniffer-annotations:jar:1.24:compile
However, we don't necessarily need to upgrade it project-wide. I sent up #7883 to revert this change in hadoop-project/pom.xml and mention the versioning needs entirely within hadoop-gcp/pom.xml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up needing to revert #7883, so as it stands in the feature branch right now, it still has Guava upgrade in hadoop-project/pom.xml. Details here:
Closes apache#7656 Signed-off-by: Chris Nauroth <[email protected]>
Closes apache#7721 Signed-off-by: Chris Nauroth <[email protected]>
Closes apache#7734 Signed-off-by: Chris Nauroth <[email protected]>
Closes apache#7742 Signed-off-by: Chris Nauroth <[email protected]>
Closes apache#7761 Co-authored-by: Chris Nauroth <[email protected]> Signed-off-by: Chris Nauroth <[email protected]>
Closes apache#7773 Signed-off-by: Chris Nauroth <[email protected]>
Closes apache#7779 Co-authored-by: Chris Nauroth <[email protected]> Signed-off-by: Chris Nauroth <[email protected]>
Closes apache#7797 Signed-off-by: Chris Nauroth <[email protected]>
Closes apache#7872 Signed-off-by: Shilun Fan <[email protected]>
Closes apache#7877 Signed-off-by: Ayush Saxena <[email protected]> Reviewed-by: Arunkumar Chacko <[email protected]>
Closes apache#7883 Signed-off-by: Shilun Fan <[email protected]> Reviewed-by: Cheng Pan <[email protected]>
Closes apache#7891 Signed-off-by: Shilun Fan <[email protected]>
… pom.xml." This reverts commit 44abf8e.
Closes apache#7874 Signed-off-by: Steve Loughran <[email protected]> Reviewed-by: Arunkumar Chacko <[email protected]> Reviewed-by: Cheng Pan <[email protected]>
… and mark exclusion in hadoop-tools-dist. Closes apache#7904 Signed-off-by: Shilun Fan <[email protected]>
Closes apache#7910 Signed-off-by: Shilun Fan <[email protected]>
…rviceLoader file. Closes apache#7916 Signed-off-by: Shilun Fan <[email protected]>
faff8a4
to
ba3a887
Compare
Description of PR
Add native support for GCS connector
How was this patch tested?
The new module contains integration tests that we've run against a live GCS bucket.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?