-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19343: Add hadoop-gcp configuration to core-default.xml and ServiceLoader file. #7916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+209
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rviceLoader file.
@steveloughran and @mukund-thakur , respectfully requesting review. Thank you! |
💔 -1 overall
This message was automatically generated. |
slfan1989
approved these changes
Aug 29, 2025
@cnauroth From my side, +1, but we need to fix the TestCommonConfigurationFields unit test. |
cnauroth
added a commit
that referenced
this pull request
Aug 29, 2025
…rviceLoader file. Closes #7916 Signed-off-by: Shilun Fan <[email protected]>
cnauroth
added a commit
that referenced
this pull request
Aug 29, 2025
…rviceLoader file. Closes #7916 Signed-off-by: Shilun Fan <[email protected]>
I committed this to the feature branch with the test fix. Thank you, @slfan1989 . |
cnauroth
added a commit
to cnauroth/hadoop
that referenced
this pull request
Aug 29, 2025
…rviceLoader file. Closes apache#7916 Signed-off-by: Shilun Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
HADOOP-19343: Add hadoop-gcp configuration to core-default.xml and ServiceLoader file.
This is in sync with configuration documentation here:
https://github.com/apache/hadoop/blob/HADOOP-19343/hadoop-tools/hadoop-gcp/src/site/markdown/tools/hadoop-gcp/Configuration.md
How was this patch tested?
I ran all hadoop-gcp integration tests, and they passed. I also built a distro and manually tested a few
hadoop fs
commands targetinggs://
URIs.For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?