Skip to content

Conversation

cnauroth
Copy link
Contributor

Description of PR

HADOOP-19343: Add hadoop-gcp configuration to core-default.xml and ServiceLoader file.

This is in sync with configuration documentation here:

https://github.com/apache/hadoop/blob/HADOOP-19343/hadoop-tools/hadoop-gcp/src/site/markdown/tools/hadoop-gcp/Configuration.md

How was this patch tested?

I ran all hadoop-gcp integration tests, and they passed. I also built a distro and manually tested a few hadoop fs commands targeting gs:// URIs.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@cnauroth
Copy link
Contributor Author

@steveloughran and @mukund-thakur , respectfully requesting review. Thank you!

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ HADOOP-19343 Compile Tests _
+0 🆗 mvndep 9m 38s Maven dependency ordering for branch
+1 💚 mvninstall 23m 46s HADOOP-19343 passed
+1 💚 compile 8m 37s HADOOP-19343 passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 7m 27s HADOOP-19343 passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 mvnsite 1m 27s HADOOP-19343 passed
+1 💚 javadoc 1m 14s HADOOP-19343 passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 1m 5s HADOOP-19343 passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 shadedclient 74m 15s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 7m 56s the patch passed
+1 💚 compile 8m 58s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javac 8m 58s the patch passed
+1 💚 compile 7m 58s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 javac 7m 58s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 13s the patch passed
+1 💚 javadoc 1m 1s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 51s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 shadedclient 27m 22s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 18m 34s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
+1 💚 unit 0m 24s hadoop-gcp in the patch passed.
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
147m 58s
Reason Tests
Failed junit tests hadoop.conf.TestCommonConfigurationFields
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7916/1/artifact/out/Dockerfile
GITHUB PR #7916
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 6b78e7eefdd2 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision HADOOP-19343 / ae9bba2
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7916/1/testReport/
Max. process+thread count 3149 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-gcp U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7916/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor

@cnauroth From my side, +1, but we need to fix the TestCommonConfigurationFields unit test.

cnauroth added a commit that referenced this pull request Aug 29, 2025
cnauroth added a commit that referenced this pull request Aug 29, 2025
@cnauroth
Copy link
Contributor Author

I committed this to the feature branch with the test fix. Thank you, @slfan1989 .

@cnauroth cnauroth closed this Aug 29, 2025
cnauroth added a commit to cnauroth/hadoop that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants