HADOOP-19343: Manage hadoop-gcp Guava version directly in its pom.xml. #7883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
💔 -1 overall
This message was automatically generated. |
slfan1989
approved these changes
Aug 19, 2025
pan3793
reviewed
Aug 19, 2025
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <version>33.1.0-jre</version> |
There was a problem hiding this comment.
the https://github.com/google/guava/blob/v33.4.8/README.md says:
- APIs without
@Betawill remain binary-compatible for the indefinite
future. (Previously, we sometimes removed such APIs after a deprecation
period. The last release to remove non-@BetaAPIs was Guava 21.0.) Even
@DeprecatedAPIs will remain (again, unless they are@Beta). We have no
plans to start removing things again, but officially, we're leaving our
options open in case of surprises (like, say, a serious security problem).
So Guava seems to ensure backward compatibility since 22, except for @Beta API? Suppose the GCS client does not use @Beta API, it is seems to be safe and simple to always use the latest Guava in the whole Hadoop project?
There was a problem hiding this comment.
Interesting, maybe it's safe to do the upgrade then.
I propose that we move ahead with this PR on the feature branch, using a targeted approach just for the hadoop-gcp module. The decision to upgrade for the whole project is a separate discussion and deserves to be tracked in a dedicated bug/PR/release note.
@arunkumarchacko is helping with a little more testing before I commit this.
There was a problem hiding this comment.
The decision to upgrade for the whole project is a separate discussion and deserves to be tracked in a dedicated bug/PR/release note.
make sense
There was a problem hiding this comment.
Thanks to @arunkumarchacko for additional testing to confirm that this works!
pan3793
approved these changes
Aug 20, 2025
|
@cnauroth LGTM. This PR can be merged from my perspective. |
cnauroth
added a commit
that referenced
this pull request
Aug 25, 2025
Closes #7883 Signed-off-by: Shilun Fan <[email protected]> Reviewed-by: Cheng Pan <[email protected]>
|
I merged this to the feature branch. Thank you for the reviews, @pan3793 and @slfan1989 . |
cnauroth
added a commit
that referenced
this pull request
Aug 25, 2025
Closes #7883 Signed-off-by: Shilun Fan <[email protected]> Reviewed-by: Cheng Pan <[email protected]>
|
Oops, I had to revert this. It works fine within the hadoop-gcp module, but the dependency convergence failures then just get pushed down to hadoop-tools-dist. (See below.) This wasn't caught in pre-commit, because at the time the distro wasn't including hadoop-gcp yet. (It was before #7877 went in.) We'll need to explore either upgrading the Guava version for the whole project or something else. |
4 tasks
cnauroth
added a commit
to cnauroth/hadoop
that referenced
this pull request
Aug 29, 2025
Closes apache#7883 Signed-off-by: Shilun Fan <[email protected]> Reviewed-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Instead of upgrading the Guava version for the whole project, manage the version specifically needed just in hadoop-gcp due to its GCS SDK dependencies.
How was this patch tested?
Full build with all GCS integration tests.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?