Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 22, 2017

Fixes the menu panel having a wrong max-height and uses a variables to reduce it, instead of a hardcoded value.

Relates to #2725.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 22, 2017
@fxck
Copy link
Contributor

fxck commented Apr 22, 2017

This is not really going to help that much I think. It needs to take in count the initial position of the trigger as well.

#3997

@crisbeto
Copy link
Member Author

Hmm true, but that may need to wait for #4155. Messing with the max-height dynamically will throw off the positioning if it's set to above, with the current setup.

Fixes the menu panel having a wrong `max-height` and uses a variables to reduce it, instead of a hardcoded value.

Relates to angular#2725.
@crisbeto crisbeto force-pushed the 2725/menu-max-height branch from dbfb260 to fb159a0 Compare April 22, 2017 17:36
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fxck We might just have to fix this in parts. This is a step in the right direction.

@kara kara removed their assignment Apr 24, 2017
@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 24, 2017
@mmalerba mmalerba merged commit d3210e7 into angular:master Apr 25, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants