Skip to content

md-menu max-height is not calculated properly  #3997

@fxck

Description

@fxck

this is unrelated to #2725 (actually looking at the issue again, kara mentions it) / #3918

this gist shows the current behaviour as well as behaviour once #3918 is merged and a situation where neither would help https://gist.run/?id=58d5fecb56107042ea0d8786f6a23f5d

I'm not sure what the intended behaviour was supposed to be, but I think it should be one of these

1.a) menu takes in account the position of the trigger, and open the panel which has height of window height - 48px - position of the trigger, ending up with this
image

1.b) same as 1a, but it open above, when current position of the trigger in view port is closer to button, ending up with this
image

  1. it doesn't take in account the position of the trigger, but expands above and below the trigger, filling up the whole page
    image

  2. it stays 100vh - 48px, but actually expands the body height, so you can actually scroll to the part that goes off screen (I don't think this is neither really possible given how overlay works, nor good for UX)

@crisbeto @kara @jelbourn @M-a-c

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions