Skip to content

Conversation

@M-a-c
Copy link
Contributor

@M-a-c M-a-c commented Apr 5, 2017

The Material Design spec says the max height of a menu should be one row height less than the page height.

Fixes #2725

Brings up more questions like:

  • Is there a minimum height in the MD spec?
  • Should vh really be used because menus can be inside of components?

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 5, 2017
@willshowell
Copy link
Contributor

The fix looks to have been made in #4214

@jelbourn jelbourn closed this Aug 23, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

md-menu is defaulted to max-height: calc(100vh + 48px); and goes off page

4 participants