Fix PHP Deprecated: Hook woocommerce_rest_api_option_permissions #10636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +244 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
includes/admin/class-wc-rest-payments-settings-option-controller.php
Outdated
Show resolved
Hide resolved
includes/admin/class-wc-rest-payments-settings-option-controller.php
Outdated
Show resolved
Hide resolved
allie500
reviewed
Mar 26, 2025
includes/admin/class-wc-rest-payments-settings-option-controller.php
Outdated
Show resolved
Hide resolved
…option_permissions
- Change from option_key to option_name
…option_permissions
…option_permissions
RadoslavGeorgiev
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
The changes look excellent!
Of course, I could not test all individual options, but the code changes make sense. I only tested the new Fraud Protection tools on a Jurassic Ninja site, and it worked as expected.
Maybe a second set of eyes (looking at you @allie500 🤣) would be a great sanity check. Otherwise 
mgascam
reviewed
Mar 27, 2025
includes/admin/class-wc-rest-payments-settings-option-controller.php
Outdated
Show resolved
Hide resolved
allie500
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Thanks for the comprehensive fix! I left some nitpicks regarding use of await. There's also an unused import of useDispatch on line 9 in client/overview/modal/progressive-onboarding-eligibility/index.tsx that we can remove.
I tested the wcpay_fraud_protection_welcome_tour_dismissed flow and it worked as expected.
Aside from the await and unused import nitpicks, I'm approving the PR.
| await updateOptions( { | ||
| wcpay_connection_success_modal_dismissed: true, | ||
| } ); | ||
| await saveOption( 'wcpay_connection_success_modal_dismissed', true ); |
There was a problem hiding this comment.
Nitpick: We can remove await here.
…option_permissions
htdat
deleted the
fix/7864-deprecated-woocommerce_rest_api_option_permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7864
TODOs:
Changes proposed in this Pull Request
/wp-json/wc/v3/payments/settings/{option_key}saveOptionin JS code so that we can send the direct REST API request to the endpoint above. This will replaceupdateOptionsprovided by Woo core, which uses the Woo core Options REST API.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge