Remove fraud protection discoverability and update tour #10558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -34 kB (-3%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
@ismaeldcom Is there any way to add some sort of padding at the top on mobile? When I test in that view, the automatic scrolling scrolls the highlighted section to the top, but that gets hidden behind the header bar.
|
Great catch @jessepearson, I somehow misplaced Let me know what you think after pulling 28994a4 🙂 |
jessepearson
approved these changes
Mar 20, 2025
# Conflicts: # client/overview/index.js
|
👋 @ismaeldcom - It seems there are still some leftovers, which makes me a bit confused when looking at the relevant option keys. I remembered that last week, I could see the banner but with the latest woocommerce-payments/client/globals.d.ts Line 117 in fff213c |
6 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9726
Changes proposed in this Pull Request
fraud-risk-tools-bannercode.new featurewording.The issue criteria is
show for new merchants the first time they navigate to the Payments → Settings page, but after testing I think it leads to an awkward user experience as they are presented with it directly. Instead, I've decided to show it when the fraud settings are visible, either by scrolling or directly linking.Since the boxes were all over the place, I updated their referenced elements and switched to spotlight mode, which points to a specific part better. And fixed the arrow and mobile issues.
Testing instructions
npm run build:clientScreenshots
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge