Remove await and opt wcpay_date_format_notice_dismissed

Author: htdat

client/overview/modal/connection-success/index.tsx

@@ -23,7 +23,7 @@ export const ConnectionSuccessModal = () => {
 		setIsDismissed( true );
 
 		// Update the option to mark the modal as dismissed.
-		await saveOption( 'wcpay_connection_success_modal_dismissed', true );
+		saveOption( 'wcpay_connection_success_modal_dismissed', true );
 	};
 
 	return (

client/overview/modal/progressive-onboarding-eligibility/index.tsx

@@ -6,7 +6,6 @@ import { __, sprintf } from '@wordpress/i18n';
 import { addQueryArgs } from '@wordpress/url';
 import { Button, Modal } from '@wordpress/components';
 import { Icon, store, currencyDollar } from '@wordpress/icons';
-import { useDispatch } from '@wordpress/data';
 import interpolateComponents from '@automattic/interpolate-components';
 
 /**

client/overview/task-list/index.js

@@ -52,7 +52,7 @@ const TaskList = ( { overviewTasksVisibility, tasks } ) => {
 		dismissedTasks.splice( dismissedTodoTasks.indexOf( key ), 1 );
 		setVisibleTasks( getVisibleTasks() );
 
-		await saveOption( optionName, updatedDismissedTasks );
+		saveOption( optionName, updatedDismissedTasks );
 	};
 
 	const dismissSelectedTask = async ( {
@@ -66,7 +66,7 @@ const TaskList = ( { overviewTasksVisibility, tasks } ) => {
 		dismissedTasks.push( key );
 		setVisibleTasks( getVisibleTasks() );
 
-		await saveOption( optionName, [ ...dismissedTasks ] );
+		saveOption( optionName, [ ...dismissedTasks ] );
 
 		createNotice( 'success', noticeMessage, {
 			actions: [
@@ -116,7 +116,7 @@ const TaskList = ( { overviewTasksVisibility, tasks } ) => {
 		delete remindMeLaterTodoTasks[ key ];
 		setVisibleTasks( getVisibleTasks() );
 
-		await saveOption(
+		saveOption(
 			'woocommerce_remind_me_later_todo_tasks',
 			updatedRemindMeLaterTasks
 		);

client/plugins-page/index.js

@@ -39,7 +39,7 @@ const PluginsPage = () => {
 		const currentDate = new Date();
 
 		// Update modal dismissed option.
-		await saveOption( 'wcpay_exit_survey_last_shown', currentDate );
+		saveOption( 'wcpay_exit_survey_last_shown', currentDate );
 
 		window.wcpayPluginsSettings.exitSurveyLastShown = currentDate;
 

includes/admin/class-wc-rest-payments-settings-option-controller.php

@@ -30,7 +30,6 @@ class WC_REST_Payments_Settings_Option_Controller extends WC_Payments_REST_Contr
 		'wcpay_duplicate_payment_method_notices_dismissed',
 		'wcpay_exit_survey_dismissed',
 		'wcpay_instant_deposit_notice_dismissed',
-		'wcpay_date_format_notice_dismissed',
 	];
 
 	/**