Skip to content

Show error dialog box on invalid global_config.json #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

Show error dialog box on invalid global_config.json #1425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c0a579
enterprise: Show error dialogbox on invalid JSON.
shubham-padia Jun 6, 2025
6d8ed98
enterprise: Quit app after showing error for invalid global config.
shubham-padia Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/common/enterprise-util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import {app} from "electron/main";
Copy link
Member

@andersk andersk Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work. We’re in app/common here, which is used from both the main process and the renderer process. We’re not allowed to use main process APIs. In practice, we get app === undefined in the renderer process.

Copy link
Member Author

@shubham-padia shubham-padia Jun 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would #1430 be the right approach for rectifying this?

import fs from "node:fs";
import path from "node:path";
import process from "node:process";

import {z} from "zod";
import {dialog} from "zulip:remote";

import {enterpriseConfigSchemata} from "./config-schemata.js";
import Logger from "./logger-util.js";
Expand Down Expand Up @@ -40,8 +42,17 @@ function reloadDatabase(): void {
.partial()
.parse(data);
} catch (error: unknown) {
dialog.showErrorBox(
"Error loading global_config",
"We encountered an error while reading global_config.json, please make sure the file contains valid JSON.",
);
logger.log("Error while JSON parsing global_config.json: ");
logger.log(error);
// This function is called multiple times throughout the
// codebase, making the above dialog.showErrorBox appear
// multiple times and then leading to a non-working app.
// It might be better to quit the app instead.
app.quit();
}
} else {
configFile = false;
Expand Down