Show error dialog box on invalid global_config.json

[shubham-padia]

Fixes #1404.

Supersedes #1405. Since the content of the commit was very similar, I have added @sammamama as a co author.

I wasn't sure about quitting the app after the error so kept it as a separate commit if we want to skip it.

Screenshots and screen captures:

Platforms this PR was tested on:

• Windows
• macOS
• Linux (specify distro)

Self-review checklist

• Self-reviewed the changes for clarity and maintainability
  (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

• Explains differences from previous plans (e.g., issue description).
• Highlights technical choices and bugs encountered.
• Calls out remaining decisions and concerns.
• Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

• Each commit is a coherent idea.
• Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

• Visual appearance of the changes.
• Responsiveness and internationalization.
• Strings and tooltips.
• End-to-end functionality of buttons, interactions and flows.
• Corner cases, error conditions, and easily imagined bugs.

[timabbott]

Would it make sense to show the actual JSON parser error message? Having a line number in the file to look at can help folks a lot. We could probably cut some of the text if we added that.

[shubham-padia]

I set global_config.json to just be test for the below error message, changing it to valid JSON makes the app work again.

The message is not really useful, the stacktrace I get is the following.

endering chunks (1)...App threw an error during load
ReferenceError: Cannot access 'logger$7' before initialization
    at getConfigItem (/Users/shubhampadia/zulip-desktop/dist-electron/index.js:14239:5)
    at Object.<anonymous> (/Users/shubhampadia/zulip-desktop/dist-electron/index.js:14191:18)
    at Module._compile (node:internal/modules/cjs/loader:1569:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1722:10)
    at Module.load (node:internal/modules/cjs/loader:1296:32)
    at Module._load (node:internal/modules/cjs/loader:1115:12)
    at c._load (node:electron/js2c/node_init:2:18008)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:227:24)
    at cjsLoader (node:internal/modules/esm/translators:266:5)

which I think makes things more confusing. Might be better to just stick with the current generic message?

[timabbott]

Yeah, this seems fine given that, merged, thanks @shubham-padia!

[andersk]

This does not work. We’re in app/common here, which is used from both the main process and the renderer process. We’re not allowed to use main process APIs. In practice, we get app === undefined in the renderer process.

[shubham-padia]

Would #1430 be the right approach for rectifying this?

[andersk]

• Reverted in Prohibit main-only and renderer-only APIs in wrong processes #1432.