Skip to content

Option improvement #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Option improvement #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Uno.Core/Options/Option.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public abstract class Option
/// <summary>
/// Creates an option for a given value.
/// </summary>
public static Some<T> Some<T>(T value) => new Some<T>(value);
public static Option<T> Some<T>(T value) => new Some<T>(value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a binary breaking change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it is. But it should be completed anyway.


protected internal Option(OptionType type)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Uno.Core/Options/Some.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,6 @@ public override int GetHashCode()
/// <summary>
/// Implicit conversion of T to <see cref="Some{T}"/>
/// </summary>
public static implicit operator Some<T>(T o) => Some(o);
public static implicit operator Some<T>(T o) => Some(o) as Some<T>;
}
}