Option improvement #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr1rrb
approved these changes
Jun 5, 2018
jeromelaban
reviewed
Jun 5, 2018
| @@ -29,7 +29,7 @@ public abstract class Option | |||
| /// <summary> | |||
| /// Creates an option for a given value. | |||
| /// </summary> | |||
| public static Some<T> Some<T>(T value) => new Some<T>(value); | |||
| public static Option<T> Some<T>(T value) => new Some<T>(value); | |||
There was a problem hiding this comment.
This is a binary breaking change.
There was a problem hiding this comment.
Yep it is. But it should be completed anyway.
carldebilly
force-pushed
the
dev/cdb/option-some-as-option
branch
from
47ca510 to
976b3d3
Compare
|
Very old PR ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.