Skip to content

Conversation

@Zfinix
Copy link
Contributor

@Zfinix Zfinix commented Mar 23, 2022

No description provided.

@Zfinix Zfinix requested review from andrzejchm and wal33d006 and removed request for andrzejchm March 23, 2022 11:15
@Zfinix
Copy link
Contributor Author

Zfinix commented Mar 23, 2022

@andrzejchm this pr is needed for pull #237

Copy link
Contributor

@andrzejchm andrzejchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor thing and we're good to merge :)

}) : _store = storage ?? const FlutterSecureStorage();

final FlutterSecureStorage _store;
static const iosOptions = IOSOptions(accessibility: IOSAccessibility.passcode);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also update other methods to use those constants aswell?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Zfinix Zfinix requested a review from andrzejchm March 23, 2022 19:57
@andrzejchm
Copy link
Contributor

I'll merge it already, @wal33d006 feel free to add your review aswell

@andrzejchm andrzejchm merged commit e1f9399 into main Mar 24, 2022
@andrzejchm andrzejchm deleted the feat/clear-local-storage-data-store branch March 24, 2022 08:34
@wal33d006
Copy link
Contributor

I had a look at it, looks good. Forgot to approve it 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants