feat: clear local storage #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wal33d006
reviewed
Mar 21, 2022
| final _secureCleared = await _secureDataStore.clearAllData(); | ||
| final _plainCleared = await _plainDataStore.clearAllData(); | ||
| _secureCleared.fold(left, right); | ||
| return _plainCleared.fold(left, right); |
Contributor
There was a problem hiding this comment.
Secure and plain data clearing should be in separate methods both returning Future<Either<CredentialsStorageFailure, bool>> and both of them separately being called in this clearCredentials function.
Contributor
There was a problem hiding this comment.
Also, this should be wrapped in try catch block.
wal33d006
reviewed
Mar 21, 2022
| await storageFile.delete(); | ||
| return right(true); | ||
| } catch (e) { | ||
| return right(false); |
Contributor
There was a problem hiding this comment.
I think this needs to be
catch(ex, stack) {
return left(CredentialsStorageFailure(
'Error while clearing data in Biometric storage',
cause: ex,
stack: stack,
))
}
wal33d006
reviewed
Mar 21, 2022
wal33d006
suggested changes
Mar 21, 2022
Contributor
wal33d006
left a comment
wal33d006
left a comment
There was a problem hiding this comment.
Awesome!
Just a few minor comments!
andrzejchm
suggested changes
Mar 21, 2022
Contributor
andrzejchm
left a comment
andrzejchm
left a comment
There was a problem hiding this comment.
good work! just few minor comments from my side
packages/transaction_signing_gateway/lib/storage/cosmos_key_info_storage.dart
Outdated
Show resolved
Hide resolved
packages/transaction_signing_gateway/lib/storage/flutter_secure_storage_data_store.dart
Outdated
Show resolved
Hide resolved
…fo_storage.dart Co-authored-by: Andrzej Chmielewski <[email protected]>
…int/flutter into feat/clear-local-storage
Contributor
Author
|
This is finally ready to be merged @andrzejchm @wal33d006 |
Contributor
|
love it! |
andrzejchm
approved these changes
Mar 26, 2022
wal33d006
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates methods to clear data from
SecureDataStore,KeyInfoStorageandPlainDataStore