Skip to content

Conversation

@kmruehl
Copy link

@kmruehl kmruehl commented Aug 23, 2021

@ssolson this PR into your fork does the following for consistency with IEC TC114 -2 Annex C (and WEC-Sim WEC-Sim/WEC-Sim#365):

  • removes the Bretschneider (BS) spectrum, in this form it is a duplication of the Pierson-Moskowitz (PM) spectrum
  • minor updates to the JONSWAP (JS) spectrum so that it is more clearly an expansion of the PM spectrum, per IEC TC 114 -2 Annex C.
  • updates the BS tests to include Hs, since its definition is now a function of both Tp and Hs

@ssolson ssolson merged commit 1cf38af into ssolson:spectrum Aug 25, 2021
@ssolson
Copy link
Owner

ssolson commented Aug 25, 2021

Thank you Kelly!

ssolson added a commit that referenced this pull request Sep 29, 2021
* Update JS and PM to match IEC

* Fix bug and adjust tests.

* remove BS and update JS (#2)

* remove BS and update JS

* updated function reference to IEC TS62600-2

* replace BS calls with JS in tests

Co-authored-by: Kelley Ruehl <[email protected]>
ssolson pushed a commit that referenced this pull request Oct 20, 2021
ssolson pushed a commit that referenced this pull request Jan 5, 2023
Specify exclusion of hindcast API modules from standard coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants