Update JS and PM to match IEC #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
This PR looks good for what changes were made. I am running into an unrelated issue running the tests on my computer due to the NDBC functions, so I have not been able to fully verify this PR. |
rpauly18
approved these changes
Aug 11, 2021
Contributor
rpauly18
left a comment
rpauly18
left a comment
There was a problem hiding this comment.
This is ready to be merged. I am still getting unrelated errors when I try to run the tests, but I think it is an issue on my machine.
* remove BS and update JS * updated function reference to IEC TS62600-2
kmruehl
approved these changes
Aug 26, 2021
Contributor
kmruehl
left a comment
kmruehl
left a comment
There was a problem hiding this comment.
Looks good, but not all tests are passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #39