[DEST-876] appboy (aka braze) use serverWorkerLocation from settings if available #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpsamson
approved these changes
Aug 8, 2019
Contributor
gpsamson
left a comment
gpsamson
left a comment
There was a problem hiding this comment.
Don't forget to add it in partner-portal and enable it for the CDN!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use serverWorkerLocation from settings if available.
Are there breaking changes in this PR?
No.
Any background context you want to provide?
One customer has service worker in a different location, so we need to allow the customer to tell Braze about that.
Is there parity with the server-side/android/iOS integration components (if applicable)?
Not applicable I believe.
Does this require a new integration setting? If so, please explain how the new setting works
Yes. It will be an optional integration String setting called serviceWorkerLocation.
Links to helpful docs and other external resources
Ticket: segment.atlassian.net/browse/DEST-876
appboy web sdk docs: js.appboycdn.com/web-sdk/latest/doc/module-appboy.html