[DEST-877] [DEST-876] Braze: Remove nested objects/arrays, Add undefined trait checks, use serverWorkerLocation from settings if available #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mericsson
approved these changes
Aug 8, 2019
[DEST-876] appboy (aka braze) use serverWorkerLocation from settings if available
mericsson
changed the title
mericsson
changed the title
NikoRoberts
approved these changes
Aug 8, 2019
Contributor
NikoRoberts
left a comment
NikoRoberts
left a comment
There was a problem hiding this comment.
So the array issue was caught when running the tests? And the unit tests actually caught it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
identifymethodtrackmethodThis is a combination of #153, #167, #170, #176 ! Three (3) changes were originally written by @NikoRoberts but had to be reverted and a bad conditional had to be fixed. One change (#176) is originally written by @mericsson.
Are there breaking changes in this PR?
Negative
Any background context you want to provide?
Is there parity with the server-side/android/iOS integration components (if applicable)?
Does this require a new integration setting? If so, please explain how the new setting works
Links to helpful docs and other external resources