Fixing App Boy Braze calls when values are undefined #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpsamson
approved these changes
Aug 4, 2019
Contributor
gpsamson
left a comment
gpsamson
left a comment
There was a problem hiding this comment.
Awesome work fixing #110, @NikoRoberts ! Let's push bump this version up ato1.10.2and I'll make the respective updates to our test sources.
Contributor
Author
|
@gpsamson done :) |
Contributor
|
Awesome. I'll update things on our end first thing tomorrow morning and shoot you an email. Thanks! @NikoRoberts |
patrickotoole
pushed a commit
to rockerbox/analytics.js-integrations
that referenced
this pull request
Feb 27, 2020
* Fixing App Boy Braze calls when values are undefined * Bump Braze integration version
marinhero
pushed a commit
to Wootric/analytics.js-integrations-1
that referenced
this pull request
Apr 24, 2020
* Fixing App Boy Braze calls when values are undefined * Bump Braze integration version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix for issue #110
Currently when injecting Braze SDK with Segment dashboard. There are non-fatal errors being reported because user data isn't in the identify or track calls.
This data is optional, so raising an error when it is not provided doesn't seem to make sense.
Are there breaking changes in this PR?
No
Any background context you want to provide?
Is there parity with the server-side/android/iOS integration components (if applicable)?
Does this require a new integration setting? If so, please explain how the new setting works
Links to helpful docs and other external resources