fix: Add error for non-int str-insert index #1439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
added a commit
to nschonni/libsass
that referenced
this pull request
Jul 17, 2019
nex3
approved these changes
Jul 17, 2019
There was a problem hiding this comment.
Thanks for fixing a bunch of these small compatibility issues! It looks like a lot of the ones you're knocking out are categorized as P3 though, which means they'll have relative low impact... would you be willing to work on some P1 compatibility issues? In particular I'd really love to see /-as-division get deprecated in LibSass so we can land it in Dart Sass as well.
|
My C++ is pretty limited, so I'm just knocking off the stuff I understand. I'm not sure if some of that larger stuff is being handled in @mgreter Dart Sass compatibility PR |
nschonni
added a commit
to nschonni/libsass
that referenced
this pull request
Jul 18, 2019
[skip libsass]
nschonni
force-pushed
the
fix--Add-error-for-non-int-str-insert-index
branch
from
5b161eb to
5eb9419
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip libsass]