Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Conversation

@nschonni
Copy link
Collaborator

@nschonni
Copy link
Collaborator Author

@mgreter I tried swapping the double to an int, but that didn't work out 😝
Hope this makes sense

@nschonni nschonni closed this Jul 17, 2019
@nschonni nschonni reopened this Jul 17, 2019
@nschonni nschonni force-pushed the fix--Error-on-non-int-str-insert-index branch from 44e0ce9 to 1e23b4d Compare July 18, 2019 05:43
@nschonni nschonni requested a review from mgreter July 19, 2019 00:30
@nschonni
Copy link
Collaborator Author

@mgreter should I port over you "assertInt" instead?

@mgreter
Copy link
Contributor

mgreter commented Jul 21, 2019

Don't mind, the "invertInt" is part of a WIP branch ...

Copy link
Contributor

@mgreter mgreter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nschonni nschonni merged commit 996dbb3 into sass:master Jul 26, 2019
@nschonni nschonni deleted the fix--Error-on-non-int-str-insert-index branch July 26, 2019 01:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

str-insert() should require an integer index

2 participants