Skip to content

Upgrade criterion #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 29, 2024
Merged

Upgrade criterion #1439

merged 13 commits into from
Apr 29, 2024

Conversation

@dhardy
Copy link
Member

@dhardy dhardy commented Apr 27, 2024 •
edited
Loading

  • Added a CHANGELOG.md entry

Summary

Built from #1329:

  • Move rand_benches → benches and merge with rand_distr/benches.
  • Use Cargo.lock.msrv to pin versions; remove direct pin on Rayon versions

@dhardy dhardy requested a review from vks April 27, 2024 08:06
@dhardy
Copy link
Member Author

dhardy commented Apr 27, 2024

Note: we should probably eventually move all benchmarks to Criterion, but that's not a job for this PR.

To avoid name-clash, the non-Criterion distributions benchmark was renamed to base_distributions.

@dhardy dhardy mentioned this pull request Apr 27, 2024
Merged
@vks vks merged commit 089d993 into rust-random:master Apr 29, 2024
@dhardy dhardy deleted the upgrade-criterion branch July 8, 2024 10:20
benjamin-lieser pushed a commit to benjamin-lieser/rand that referenced this pull request Feb 5, 2025
@vks
Merge pull request rust-random#1439 from dhardy/upgrade-criterion
ce7fd64 
Upgrade criterion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vks vks vks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhardy @vks