Rename Rng::gen to Rng::random
#1438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewtato
reviewed
Apr 26, 2024
This anticipates `gen` being a keyword in Rust 2024. A deprecated alias for `Rng::gen` stays in place to make the transition easier. Fixes rust-random#1435.
benjamin-lieser
pushed a commit
to benjamin-lieser/rand
that referenced
this pull request
Feb 5, 2025
vadorovsky
added a commit
to vadorovsky/agave
that referenced
this pull request
May 16, 2025
Doing so allows us to upgrade Rust edition to 2024 and consume the change which allows to avoid a conflict of `Rng::gen` with the `gen` keyword by renaming it to `Rng::random` (rust-random/rand/pull/1438).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1435.