Skip to content

Conversation

@jtepe
Copy link

@jtepe jtepe commented Jan 16, 2016

  • Moved semicolon to the right place in the let statement in the ZST section.
  • Fixed the missing ZST additions for RawValIter<T> from this section in the final code section.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@jtepe
Copy link
Author

jtepe commented Jan 16, 2016

r? @gankro

@rust-highfive rust-highfive assigned Gankra and unassigned Manishearth Jan 16, 2016
@Gankra
Copy link
Contributor

Gankra commented Jan 16, 2016

The indentation of those ifs seems unidiomatic. I do:

let x = if foo() {
    a
} else {
    b
}

But maybe the community has drifted from that?

@Gankra
Copy link
Contributor

Gankra commented Jan 16, 2016

r=me on the content of the patch, though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you have literal tabs in the file, you should indent with only spaces.

@jtepe
Copy link
Author

jtepe commented Jan 16, 2016

Damn Emacs config ...

@alexcrichton
Copy link
Member

@bors: r=Gankro 5c62178

Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 17, 2016
… r=Gankro

* Moved semicolon to the right place in the `let` statement in the ZST section.
* Fixed the missing ZST additions for `RawValIter<T>` from this section in the final code section.
bors added a commit that referenced this pull request Jan 17, 2016
@bors bors merged commit 5c62178 into rust-lang:master Jan 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants