std: Stabilize APIs for the 1.7 release #30943

alexcrichton · 2016-01-15T21:18:00Z

This commit stabilizes and deprecates the FCP (final comment period) APIs for
the upcoming 1.7 beta release. The specific APIs which changed were:

Stabilized

Path::strip_prefix (renamed from relative_from)
path::StripPrefixError (new error type returned from strip_prefix)
Ipv4Addr::is_loopback
Ipv4Addr::is_private
Ipv4Addr::is_link_local
Ipv4Addr::is_multicast
Ipv4Addr::is_broadcast
Ipv4Addr::is_documentation
Ipv6Addr::is_unspecified
Ipv6Addr::is_loopback
Ipv6Addr::is_unique_local
Ipv6Addr::is_multicast
Vec::as_slice
Vec::as_mut_slice
String::as_str
String::as_mut_str
<[T]>::clone_from_slice - the usize return value is removed
<[T]>::sort_by_key
i32::checked_rem (and other signed types)
i32::checked_neg (and other signed types)
i32::checked_shl (and other signed types)
i32::checked_shr (and other signed types)
i32::saturating_mul (and other signed types)
i32::overflowing_add (and other signed types)
i32::overflowing_sub (and other signed types)
i32::overflowing_mul (and other signed types)
i32::overflowing_div (and other signed types)
i32::overflowing_rem (and other signed types)
i32::overflowing_neg (and other signed types)
i32::overflowing_shl (and other signed types)
i32::overflowing_shr (and other signed types)
u32::checked_rem (and other unsigned types)
u32::checked_shl (and other unsigned types)
u32::saturating_mul (and other unsigned types)
u32::overflowing_add (and other unsigned types)
u32::overflowing_sub (and other unsigned types)
u32::overflowing_mul (and other unsigned types)
u32::overflowing_div (and other unsigned types)
u32::overflowing_rem (and other unsigned types)
u32::overflowing_neg (and other unsigned types)
u32::overflowing_shl (and other unsigned types)
u32::overflowing_shr (and other unsigned types)
ffi::IntoStringError
CString::into_string
CString::into_bytes
CString::into_bytes_with_nul
From<CString> for Vec<u8>
From<CString> for Vec<u8>
IntoStringError::into_cstring
IntoStringError::utf8_error
Error for IntoStringError

Deprecated

Path::relative_from - renamed to strip_prefix
Path::prefix - use components().next() instead
os::unix::fs constants - moved to the libc crate
fmt::{radix, Radix, RadixFmt} - not used enough to stabilize
IntoCow - conflicts with Into and may come back later
i32::{BITS, BYTES} (and other integers) - not pulling their weight
DebugTuple::formatter - will be removed
sync::Semaphore - not used enough and confused with system semaphores

Closes #23284
cc #27709 (still lots more methods though)
Closes #27712
Closes #27722
Closes #27728
Closes #27735
Closes #27729
Closes #27755
Closes #27782
Closes #27798

rust-highfive · 2016-01-15T21:18:12Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2016-01-15T21:19:11Z

r? @aturon

Note that this PR currently leaves out the stabilization of custom hashers in hashmaps because there's a bit of a question of where the BuildHasher trait goes that we didn't quite make an explicit decision on. I'd be fine backporting that stabilization, however.

aturon · 2016-01-15T22:38:37Z

src/libstd/net/ip.rs

Should we disambiguate this RFC from our normal RFCs? Do we want to provide a link?

Nah I think that if you're reading this much into the documentation you'll probably recognize in the context that these are the other kind of RFCs. That being said if it ends up being confusing we can certainly update!

aturon · 2016-01-15T22:39:30Z

OK, r=me unless you want to deal with the tiny nit.

alexcrichton · 2016-01-15T23:01:42Z

@bors: r=aturon faded1c375f55e35f849e003b40e6bab30eb3e66

alexcrichton · 2016-01-15T23:02:40Z

oh also, cc @rust-lang/libs

ollie27 · 2016-01-15T23:19:37Z

It looks like checked_neg is still missing for unsigned ints.

alexcrichton · 2016-01-15T23:36:34Z

@bors: r-

Oh that was originally left out because it always overflowed (e.g. always returned None), but now we special case 0 and it seems good for consistency, so I'll add.

eefriedman · 2016-01-16T00:59:00Z

src/libcore/num/mod.rs

Oops, yes ideed!

alexcrichton · 2016-01-16T01:02:39Z

@bors: r=aturon 19d4a21

bors · 2016-01-16T13:56:39Z

⌛ Testing commit 19d4a21 with merge 0246765...

bors · 2016-01-16T14:11:28Z

💔 Test failed - auto-linux-64-x-android-t

alexcrichton · 2016-01-16T19:02:51Z

@bors: r=aturon f2e517b

This commit stabilizes and deprecates the FCP (final comment period) APIs for the upcoming 1.7 beta release. The specific APIs which changed were: Stabilized * `Path::strip_prefix` (renamed from `relative_from`) * `path::StripPrefixError` (new error type returned from `strip_prefix`) * `Ipv4Addr::is_loopback` * `Ipv4Addr::is_private` * `Ipv4Addr::is_link_local` * `Ipv4Addr::is_multicast` * `Ipv4Addr::is_broadcast` * `Ipv4Addr::is_documentation` * `Ipv6Addr::is_unspecified` * `Ipv6Addr::is_loopback` * `Ipv6Addr::is_unique_local` * `Ipv6Addr::is_multicast` * `Vec::as_slice` * `Vec::as_mut_slice` * `String::as_str` * `String::as_mut_str` * `<[T]>::clone_from_slice` - the `usize` return value is removed * `<[T]>::sort_by_key` * `i32::checked_rem` (and other signed types) * `i32::checked_neg` (and other signed types) * `i32::checked_shl` (and other signed types) * `i32::checked_shr` (and other signed types) * `i32::saturating_mul` (and other signed types) * `i32::overflowing_add` (and other signed types) * `i32::overflowing_sub` (and other signed types) * `i32::overflowing_mul` (and other signed types) * `i32::overflowing_div` (and other signed types) * `i32::overflowing_rem` (and other signed types) * `i32::overflowing_neg` (and other signed types) * `i32::overflowing_shl` (and other signed types) * `i32::overflowing_shr` (and other signed types) * `u32::checked_rem` (and other unsigned types) * `u32::checked_neg` (and other unsigned types) * `u32::checked_shl` (and other unsigned types) * `u32::saturating_mul` (and other unsigned types) * `u32::overflowing_add` (and other unsigned types) * `u32::overflowing_sub` (and other unsigned types) * `u32::overflowing_mul` (and other unsigned types) * `u32::overflowing_div` (and other unsigned types) * `u32::overflowing_rem` (and other unsigned types) * `u32::overflowing_neg` (and other unsigned types) * `u32::overflowing_shl` (and other unsigned types) * `u32::overflowing_shr` (and other unsigned types) * `ffi::IntoStringError` * `CString::into_string` * `CString::into_bytes` * `CString::into_bytes_with_nul` * `From<CString> for Vec<u8>` * `From<CString> for Vec<u8>` * `IntoStringError::into_cstring` * `IntoStringError::utf8_error` * `Error for IntoStringError` Deprecated * `Path::relative_from` - renamed to `strip_prefix` * `Path::prefix` - use `components().next()` instead * `os::unix::fs` constants - moved to the `libc` crate * `fmt::{radix, Radix, RadixFmt}` - not used enough to stabilize * `IntoCow` - conflicts with `Into` and may come back later * `i32::{BITS, BYTES}` (and other integers) - not pulling their weight * `DebugTuple::formatter` - will be removed * `sync::Semaphore` - not used enough and confused with system semaphores Closes rust-lang#23284 cc rust-lang#27709 (still lots more methods though) Closes rust-lang#27712 Closes rust-lang#27722 Closes rust-lang#27728 Closes rust-lang#27735 Closes rust-lang#27729 Closes rust-lang#27755 Closes rust-lang#27782 Closes rust-lang#27798

alexcrichton · 2016-01-16T19:03:28Z

@bors: r=aturon 9a4f43b

This commit stabilizes and deprecates the FCP (final comment period) APIs for the upcoming 1.7 beta release. The specific APIs which changed were: Stabilized * `Path::strip_prefix` (renamed from `relative_from`) * `path::StripPrefixError` (new error type returned from `strip_prefix`) * `Ipv4Addr::is_loopback` * `Ipv4Addr::is_private` * `Ipv4Addr::is_link_local` * `Ipv4Addr::is_multicast` * `Ipv4Addr::is_broadcast` * `Ipv4Addr::is_documentation` * `Ipv6Addr::is_unspecified` * `Ipv6Addr::is_loopback` * `Ipv6Addr::is_unique_local` * `Ipv6Addr::is_multicast` * `Vec::as_slice` * `Vec::as_mut_slice` * `String::as_str` * `String::as_mut_str` * `<[T]>::clone_from_slice` - the `usize` return value is removed * `<[T]>::sort_by_key` * `i32::checked_rem` (and other signed types) * `i32::checked_neg` (and other signed types) * `i32::checked_shl` (and other signed types) * `i32::checked_shr` (and other signed types) * `i32::saturating_mul` (and other signed types) * `i32::overflowing_add` (and other signed types) * `i32::overflowing_sub` (and other signed types) * `i32::overflowing_mul` (and other signed types) * `i32::overflowing_div` (and other signed types) * `i32::overflowing_rem` (and other signed types) * `i32::overflowing_neg` (and other signed types) * `i32::overflowing_shl` (and other signed types) * `i32::overflowing_shr` (and other signed types) * `u32::checked_rem` (and other unsigned types) * `u32::checked_shl` (and other unsigned types) * `u32::saturating_mul` (and other unsigned types) * `u32::overflowing_add` (and other unsigned types) * `u32::overflowing_sub` (and other unsigned types) * `u32::overflowing_mul` (and other unsigned types) * `u32::overflowing_div` (and other unsigned types) * `u32::overflowing_rem` (and other unsigned types) * `u32::overflowing_neg` (and other unsigned types) * `u32::overflowing_shl` (and other unsigned types) * `u32::overflowing_shr` (and other unsigned types) * `ffi::IntoStringError` * `CString::into_string` * `CString::into_bytes` * `CString::into_bytes_with_nul` * `From<CString> for Vec<u8>` * `From<CString> for Vec<u8>` * `IntoStringError::into_cstring` * `IntoStringError::utf8_error` * `Error for IntoStringError` Deprecated * `Path::relative_from` - renamed to `strip_prefix` * `Path::prefix` - use `components().next()` instead * `os::unix::fs` constants - moved to the `libc` crate * `fmt::{radix, Radix, RadixFmt}` - not used enough to stabilize * `IntoCow` - conflicts with `Into` and may come back later * `i32::{BITS, BYTES}` (and other integers) - not pulling their weight * `DebugTuple::formatter` - will be removed * `sync::Semaphore` - not used enough and confused with system semaphores Closes rust-lang#23284 cc rust-lang#27709 (still lots more methods though) Closes rust-lang#27712 Closes rust-lang#27722 Closes rust-lang#27728 Closes rust-lang#27735 Closes rust-lang#27729 Closes rust-lang#27755 Closes rust-lang#27782 Closes rust-lang#27798

- Successful merges: #30938, #30940, #30943, #30949, #30952, #30957, #30959 - Failed merges:

bluss · 2016-01-18T13:30:01Z

src/libcore/slice.rs

Oops, major perf regression. I'll try to PR this.

Oh gah good eye!

(for those following along the PR was submitted)

Yep, it's fine. I'm not worried, as long as it gets into the same beta release.

bluss · 2016-01-18T20:11:59Z

Now I understand why the clone_from_slice fix got a p=1. bytes::copy_memory has been replaced by calls to clone_from_slice in many places.

I'm not even sure that's a good idea. bytes::copy_memory was a safe interface to memcpy, no matter what the compilation mode. Calling clone_from_slice will be slow in no optimizations mode, and will exercise the inliner and optimizer in optimizing mode.

rust-highfive assigned nikomatsakis Jan 15, 2016

rust-highfive assigned aturon and unassigned nikomatsakis Jan 15, 2016

aturon reviewed Jan 15, 2016
View reviewed changes

alexcrichton force-pushed the stabilize-1.7 branch from 61ea7ba to faded1c Compare January 15, 2016 23:01

alexcrichton force-pushed the stabilize-1.7 branch from faded1c to 317592f Compare January 15, 2016 23:53

eefriedman reviewed Jan 16, 2016
View reviewed changes

alexcrichton force-pushed the stabilize-1.7 branch from 317592f to 19d4a21 Compare January 16, 2016 01:02

alexcrichton force-pushed the stabilize-1.7 branch from 19d4a21 to f2e517b Compare January 16, 2016 19:02

alexcrichton force-pushed the stabilize-1.7 branch from f2e517b to 9a4f43b Compare January 16, 2016 19:03

Manishearth mentioned this pull request Jan 17, 2016

Rollup of 7 pull requests #30975

Merged

bors added a commit that referenced this pull request Jan 17, 2016

Auto merge of #30975 - Manishearth:rollup, r=Manishearth

bff5292

- Successful merges: #30938, #30940, #30943, #30949, #30952, #30957, #30959 - Failed merges:

bors merged commit 9a4f43b into rust-lang:master Jan 17, 2016

bluss reviewed Jan 18, 2016
View reviewed changes

bluss mentioned this pull request Jan 18, 2016

Restore indexed formulation of clone_from_slice #31000

Merged

alexcrichton deleted the stabilize-1.7 branch January 21, 2016 01:32

This was referenced Jan 21, 2016

Tracking issue for clone_from_slice stabilization #27750

Closed

Tracking issue for num_bits_bytes stabilization #27753

Closed

Tracking issue for owned CString conversions #29157

Closed

Tracking issue for slice::sort_by_key #30423

Closed

brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 21, 2016

alexcrichton mentioned this pull request Jan 21, 2016

Safe memcpy for slices ([T]::copy_from_slice) rust-lang/rfcs#1419

Merged

mcarton mentioned this pull request Feb 29, 2016

as_slice will be stable in 1.7 rust-lang/rust-clippy#728

Closed

std: Stabilize APIs for the 1.7 release #30943

std: Stabilize APIs for the 1.7 release #30943

Uh oh!

Conversation

alexcrichton commented Jan 15, 2016

Uh oh!

rust-highfive commented Jan 15, 2016

Uh oh!

alexcrichton commented Jan 15, 2016

Uh oh!

aturon Jan 15, 2016

Choose a reason for hiding this comment

Uh oh!

alexcrichton Jan 15, 2016

Choose a reason for hiding this comment

Uh oh!

aturon commented Jan 15, 2016

Uh oh!

alexcrichton commented Jan 15, 2016

Uh oh!

alexcrichton commented Jan 15, 2016

Uh oh!

ollie27 commented Jan 15, 2016

Uh oh!

alexcrichton commented Jan 15, 2016

Uh oh!

eefriedman Jan 16, 2016

Choose a reason for hiding this comment

Uh oh!

alexcrichton Jan 16, 2016

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Jan 16, 2016

Uh oh!

bors commented Jan 16, 2016

Uh oh!

bors commented Jan 16, 2016

Uh oh!

alexcrichton commented Jan 16, 2016

Uh oh!

alexcrichton commented Jan 16, 2016

Uh oh!

bluss Jan 18, 2016

Choose a reason for hiding this comment

Uh oh!

alexcrichton Jan 18, 2016

Choose a reason for hiding this comment

Uh oh!

bluss Jan 18, 2016

Choose a reason for hiding this comment

Uh oh!

bluss commented Jan 18, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants