Fix file collapse UI regression #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase specificity of .d2h-d-none selector
Owner
|
Weird I cannot replicate the issue in the demo. |
Owner
|
The change seems, fine just weird why it would matter. |
Contributor
Author
|
The demo (at least on my machine), doesn't appear to be on the latest version, as the CSS rule for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in b164b51 where toggling the Viewed checkbox ceased hiding the file diff. Improves upon #445's implementation by increasing the specificity of the
.d2h-d-noneselector rather than using!important.Steps to reproduce
Note: this regression is not present in the diff2html demo as it's probably using an older version of the library.
Expected Results
The file should hide when "Viewed" is toggled on.