Make d2h-d-none override visibility: fix broken hiding of viewed files #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `.d2h-d-none` is the first rule in the file, other rules with the same specificity override it, e.g. line 102 in `.d2h-files-diff`. This means hiding no longer works. This commit fixes that; alternatively, the `.d2h-d-none` rule should be moved to the end of the file if you don't like `!important`.
Author
|
Hi, I see CI is failing but I don't think it's something I could fix - this PR only changed one line of CSS, after all. Any comments? |
Owner
|
Fixed in #447 Thank you for the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression: toggling Viewed no longer hides the patch for the file.
Steps to reproduce:
Expected Results:
The file should hide when "Viewed" is toggled on.
I believe the problem was introduced in b164b51
Since
.d2h-d-noneis the first rule in the file, other rules with the same specificity override it, e.g. line 102 in.d2h-files-diff. This means hiding no longer works. This commit fixes that; alternatively, the.d2h-d-nonerule should be moved to the end of the file if you don't like!important.