Properly remove the per-schema method key
#764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for it was already removed in rebing#757 but forgotten to be cleaned up properly. Therefore also the `ExampleSchemaWithMethod` is removed, as it's test actually already showed it was not honored.
mfn
added a commit
to mfn/graphql-laravel
that referenced
this pull request
Aug 11, 2021
This was initially removed in rebing#779 and fully cleaned up in rebing#764 but there might be valid reasons to change this, e.g. if one desires only POST HTTP methods for prevent basic CSRF attacks for GET requests.
9 tasks
believe2world
added a commit
to believe2world/graphql_admin_laravel
that referenced
this pull request
Apr 6, 2023
This was initially removed in rebing/graphql-laravel#779 and fully cleaned up in rebing/graphql-laravel#764 but there might be valid reasons to change this, e.g. if one desires only POST HTTP methods for prevent basic CSRF attacks for GET requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support for it was already removed in #757
but forgotten to be cleaned up properly.
Therefore also the
ExampleSchemaWithMethodis removed, as it's testactually already showed it was not honored.
Type of change:
Checklist:
composer fix-style