Merge pull request #764 from mfn/mfn-remove-method

Properly remove the per-schema `method` key

Author: mfn

CHANGELOG.md

@@ -28,6 +28,8 @@ CHANGELOG
     - 1 route for each schema + 1 route for the group prefix (default schema)
     - If GraphiQL is enabled: 1 route graphiql route for each schema + 1 for the
       graphiql group prefix (default schema)
+    - This also means that the per schema config key `method` (aka HTTP method)
+      is not supported anymore
   - It's now possible to prevent the registering of any routes by making the top
     level `route` an empty array or null
   - `\Rebing\GraphQL\GraphQL::routeNameTransformer` has been removed

config/config.php

@@ -84,7 +84,6 @@
                 // ExampleType::class,
             ],
             'middleware' => [],
-            'method' => ['get', 'post'],
         ],
     ],
 

tests/Support/Objects/ExampleSchemaWithMethod.php

@@ -7,7 +7,6 @@
 use Illuminate\Routing\Router;
 use Rebing\GraphQL\Tests\Support\Objects\ExampleMiddleware;
 use Rebing\GraphQL\Tests\Support\Objects\ExampleSchema;
-use Rebing\GraphQL\Tests\Support\Objects\ExampleSchemaWithMethod;
 use Rebing\GraphQL\Tests\TestCase;
 
 class NoRoutesRegisteredTest extends TestCase
@@ -28,11 +27,9 @@ protected function getEnvironmentSetUp($app): void
                     'middleware' => [ExampleMiddleware::class],
                 ],
                 'with_methods' => [
-                    'method' => ['post'],
                     'middleware' => [ExampleMiddleware::class],
                 ],
                 'class_based' => ExampleSchema::class,
-                'class_based_with_methods' => ExampleSchemaWithMethod::class,
                 'shorthand' => BuildSchema::build('
                     schema {
                         query: ShorthandExample

tests/Unit/NoRoutesRegisteredTest.php

@@ -8,7 +8,6 @@
 use Illuminate\Support\Collection;
 use Rebing\GraphQL\Tests\Support\Objects\ExampleMiddleware;
 use Rebing\GraphQL\Tests\Support\Objects\ExampleSchema;
-use Rebing\GraphQL\Tests\Support\Objects\ExampleSchemaWithMethod;
 use Rebing\GraphQL\Tests\TestCase;
 
 class RoutesTest extends TestCase
@@ -32,11 +31,9 @@ protected function getEnvironmentSetUp($app): void
                     'middleware' => [ExampleMiddleware::class],
                 ],
                 'with_methods' => [
-                    'method' => ['post'],
                     'middleware' => [ExampleMiddleware::class],
                 ],
                 'class_based' => ExampleSchema::class,
-                'class_based_with_methods' => ExampleSchemaWithMethod::class,
                 'shorthand' => BuildSchema::build('
                     schema {
                         query: ShorthandExample
@@ -108,17 +105,6 @@ public function testRoutes(): void
                     ExampleMiddleware::class,
                 ],
             ],
-            'graphql.class_based_with_methods' => [
-                'methods' => [
-                    'GET',
-                    'POST',
-                    'HEAD',
-                ],
-                'uri' => 'graphql_test/class_based_with_methods',
-                'middleware' => [
-                    ExampleMiddleware::class,
-                ],
-            ],
             'graphql.shorthand' => [
                 'methods' => [
                     'GET',