Skip to content

upgrade bazel.. #55986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −9
Draft

upgrade bazel.. #55986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
common --noenable_bzlmod

# Must be first. Enables build:windows, build:linux, build:macos, build:freebsd, build:openbsd
build --enable_platform_specific_config

Expand Down
2 changes: 1 addition & 1 deletion .bazelversion
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6.5.0
7.5.0
1 change: 0 additions & 1 deletion .buildkite/release-automation/verify-macos-wheels.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ if [[ $# -ne 1 ]]; then
fi

MAC_ARCH="$1" # First argument is the architecture of the machine, e.g. x86_64, arm64
export USE_BAZEL_VERSION="${USE_BAZEL_VERSION:-6.5.0}"

# Sets RAY_VERSION and RAY_COMMIT
source .buildkite/release-automation/set-ray-version.sh
Expand Down
4 changes: 2 additions & 2 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ load("@bazel_skylib//lib:versions.bzl", "versions")

# Please keep this in sync with the .bazelversion file.
versions.check(
maximum_bazel_version = "6.5.0",
minimum_bazel_version = "6.5.0",
maximum_bazel_version = "7.5.0",
minimum_bazel_version = "7.5.0",
)

load("@hedron_compile_commands//:workspace_setup.bzl", "hedron_compile_commands_setup")
Expand Down
2 changes: 1 addition & 1 deletion ci/ray_ci/test_bazel_sharding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def mock_build_dir():
with open(os.path.join(tmpdir, "WORKSPACE"), "w") as f:
f.write('workspace(name = "fake_workspace")\n')
with open(os.path.join(tmpdir, ".bazelversion"), "w") as f:
f.write("6.5.0\n")
f.write("7.5.0\n")

os.makedirs(os.path.join(tmpdir, WORKSPACE_KEY), exist_ok=True)

Expand Down
8 changes: 4 additions & 4 deletions doc/source/ray-contribute/development.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ To build Ray on Ubuntu, run the following commands:
.. note::
The `install-bazel.sh` script installs `bazelisk` for building Ray.
Note that `bazel` is installed at `$HOME/bin/bazel`; make sure it's on the executable `PATH`.
If you prefer to use `bazel`, only version `6.5.0` is currently supported.
If you prefer to use `bazel`, it only supports using `7.5.0`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrasing "it only supports using" is a bit awkward. For better clarity and conciseness, I suggest rephrasing this sentence.

Suggested change
If you prefer to use `bazel`, it only supports using `7.5.0`.
If you prefer to use `bazel`, only version `7.5.0` is supported.


For RHELv8 (Redhat EL 8.0-64 Minimal), run the following commands:

Expand Down Expand Up @@ -239,7 +239,7 @@ Building Ray on Windows (full)

The following links were correct during the writing of this section. In case the URLs changed, search at the organizations' sites.

- Bazel 6.5.0 (https://github.com/bazelbuild/bazel/releases/tag/6.5.0)
- Bazel 7.5.0 (https://github.com/bazelbuild/bazel/releases/tag/7.5.0)
- Microsoft Visual Studio 2019 (or Microsoft Build Tools 2019 - https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019)
- JDK 15 (https://www.oracle.com/java/technologies/javase-jdk15-downloads.html)
- Miniforge 3 (https://github.com/conda-forge/miniforge/blob/main/README.md)
Expand Down Expand Up @@ -271,8 +271,8 @@ You can also use the included script to install Bazel:

3. Define an environment variable ``BAZEL_SH`` to point to ``bash.exe``. If git for Windows was installed for all users, bash's path should be ``C:\Program Files\Git\bin\bash.exe``. If git was installed for a single user, adjust the path accordingly.

4. Bazel 6.5.0 installation. Go to Bazel 6.5.0 release web page and download
bazel-4.2.1-windows-x86_64.exe. Copy the exe into the directory of your choice.
4. Bazel 7.5.0 installation. Go to Bazel 7.5.0 release web page and download
bazel-7.5.0-windows-x86_64.exe. Copy the exe into the directory of your choice.
Define an environment variable BAZEL_PATH to full exe path (example:
``set BAZEL_PATH=C:\bazel\bazel.exe``). Also add the Bazel directory to the
``PATH`` (example: ``set PATH=%PATH%;C:\bazel``)
Expand Down