upgrade bazel.. #55986
Draft
upgrade bazel.. #55986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the Bazel version from 6.5.0 to 7.5.0. The changes are consistent across the codebase, including updating the .bazelversion file, build scripts, CI test configurations, and documentation. A flag to disable Bzlmod has been added, which is a reasonable step for this kind of upgrade. I have one minor suggestion to improve the wording in the development documentation.
| @@ -141,7 +141,7 @@ To build Ray on Ubuntu, run the following commands: | |||
| .. note:: | |||
| The `install-bazel.sh` script installs `bazelisk` for building Ray. | |||
| Note that `bazel` is installed at `$HOME/bin/bazel`; make sure it's on the executable `PATH`. | |||
| If you prefer to use `bazel`, only version `6.5.0` is currently supported. | |||
| If you prefer to use `bazel`, it only supports using `7.5.0`. | |||
There was a problem hiding this comment.
The phrasing "it only supports using" is a bit awkward. For better clarity and conciseness, I suggest rephrasing this sentence.
Suggested change
| If you prefer to use `bazel`, it only supports using `7.5.0`. | |
| If you prefer to use `bazel`, only version `7.5.0` is supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and of course it does not work yet..