Skip to content

Forward retry_on_empty and retries by calling transaction #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 3, 2023
Merged

Forward retry_on_empty and retries by calling transaction #1401

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
44b4e97
Forward retry_on_empty and retries to serial
cgernert Mar 2, 2023
096a8d8
Update base.py
cgernert Mar 2, 2023
a94e43f
Update base.py
cgernert Mar 2, 2023
2bd393f
Merge branch 'dev' into patch-2
janiversen Mar 3, 2023
8ba702e
Positional arguments fix and black formating
cgernert Mar 3, 2023
8e86a34
Merge branch 'dev' into patch-2
janiversen Mar 3, 2023
9f8567b
Update pymodbus/client/base.py
janiversen Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pymodbus/client/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,9 @@ def __init__(

# Common variables.
self.framer = self.params.framer(ClientDecoder(), self)
self.transaction = DictTransactionManager(self, **kwargs)
self.transaction = DictTransactionManager(
self, **{**kwargs, **{"retries": retries, "retry_on_empty": retry_on_empty}}
)
self.delay_ms = self.params.reconnect_delay
self.use_protocol = False
self._connected = False
Expand Down