Skip to content

Conversation

cgernert
Copy link
Contributor

@cgernert cgernert commented Mar 2, 2023

Fix for #1331

@cgernert cgernert changed the title Forward retry_on_empty and retries by calling transation Forward retry_on_empty and retries by calling transaction Mar 2, 2023
@janiversen
Copy link
Collaborator

You have formatting issue (black, see CI), you can run ./check_ci.sh locally to have black fix it.

Apart from that all tests fail.

@cgernert
Copy link
Contributor Author

cgernert commented Mar 3, 2023

You have formatting issue (black, see CI), you can run ./check_ci.sh locally to have black fix it.

Apart from that all tests fail.

OK, fixed it and applied black

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@janiversen janiversen merged commit 4517d33 into pymodbus-dev:dev Mar 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants