Skip to content

Refer to credentials via kube.SecretKeyRef(). Fixes #23 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2021
Merged

Refer to credentials via kube.SecretKeyRef(). Fixes #23 #24

merged 1 commit into from
Nov 25, 2021

Conversation

psy-q
Copy link
Contributor

@psy-q psy-q commented Nov 25, 2021

This refers to the existing secret instead of writing the same password into the env vars again.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Link this PR to related issues.

@psy-q psy-q added the bug Something isn't working label Nov 25, 2021
@psy-q psy-q requested a review from mhutter November 25, 2021 14:53
@psy-q psy-q self-assigned this Nov 25, 2021
@mhutter mhutter merged commit 131321b into master Nov 25, 2021
@mhutter mhutter deleted the credential_deduplication branch November 25, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhutter mhutter Awaiting requested review from mhutter

Assignees

@psy-q psy-q

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@psy-q @mhutter