Skip to content

Conversation

@anishasthana
Copy link
Contributor

@anishasthana anishasthana commented Nov 2, 2023

Closes red-hat-data-services#4

cc @jbusche

The failures have gone away, but I'm seeing the following warning now:

---- Warning Report
+------------------------+-----------------+-----------------------------------------------------------------+---------------------------------------------------+
| OPERATOR NAME          | EXECUTABLE NAME | STATUS                                                          | IMAGE                                             |
+------------------------+-----------------+-----------------------------------------------------------------+---------------------------------------------------+
| ubi8-minimal-container | /manager        | go binary has no build tags set (should have strictfipsruntime) | quay.io/anishasthana/codeflare-operator:enablecgo |
+------------------------+-----------------+-----------------------------------------------------------------+---------------------------------------------------+
---- Successful run with warnings

Image is up at quay.io/anishasthana/codeflare-operator:enablecgo.

@openshift-ci openshift-ci bot requested review from KPostOffice and dimakis November 2, 2023 20:24
@anishasthana
Copy link
Contributor Author

cc @sutaakar

@jbusche
Copy link
Collaborator

jbusche commented Nov 2, 2023

I built and scanned - Failure has gone away and is replaced with this warning:

---- Warning Report
+------------------------+-----------------+-----------------------------------------------------------------+----------------------------+
| OPERATOR NAME          | EXECUTABLE NAME | STATUS                                                          | IMAGE                      |
+------------------------+-----------------+-----------------------------------------------------------------+----------------------------+
| ubi8-minimal-container | /manager        | go binary has no build tags set (should have strictfipsruntime) | quay.io/jbusche/pr-391:rc1 |
+------------------------+-----------------+-----------------------------------------------------------------+----------------------------+
---- Successful run with warnings

I've replaced it with the existing v1.0.0 operator, and it's running ok - no issues with MCAD

All 5 appwrappers finished: 13:57:48
Total amount of time for 5 appwrappers is: 43 seconds

I'm trying it with a few of the notebook examples and it's looking good so far

Copy link
Collaborator

@jbusche jbusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbusche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 2, 2023
@openshift-ci openshift-ci bot merged commit bfadb47 into project-codeflare:main Nov 2, 2023
@anishasthana anishasthana deleted the fips_fix branch November 2, 2023 21:52
AjayJagan pushed a commit to AjayJagan/codeflare-operator that referenced this pull request Aug 7, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix FIPS compliance issues for CodeFlare Operator

2 participants