fix (some) test suite warnings

[khanniie]

Fixes the test suite warnings that are unrelated to the React lifecycle, which I assume will be resolved as a side effect of the ongoing class -> functional conversion.

Changes:

• Provides the props that were missing but marked as required in the EditorAccessibility tests and ErrorModal tests
• creates a fake version of window.confirm which is missing from the jsdom environment but used in the FileNode tests
• hides the extra log in the createProject test and changes it from a log to a warning type in the controller itself

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

[release-com]

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

• p5.js-web-editor
  • app-ted2dac.release.editor.p5js.org/
  • preview-ted2dac.release.editor.p5js.org/

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-71a56e04d9

[raclim]

This is awesome! Thanks so much for working on this!

Pinging at @nahbee10 to see if she has any additional thoughts as well—otherwise I think I'm going go ahead with merging this in tomorrow!

[raclim]

I'm going to go ahead with merging this in, but please feel free to note if any additional thoughts comes up!

[khanniie]

Yay! thanks rachel!! : )

[lindapaiste]

Personally I would say that the more logical fix for the PropTypes error would be to make it so that the service is not a required prop. It's only needed when type="oauthError" and it's not used in any other circumstance so it's kind of weird that it's always required. (I'm not sure if PropTypes has a way to require it depending on the value of the type. The "correct" thing would be to require the service if and only if the type is "oauthError" but that might be getting too complicated.)