Merge pull request #3221 from processing/develop-khanniie-testwarnings

fix (some) test suite warnings

Author: raclim

client/modules/IDE/components/EditorAccessibility.unit.test.jsx

@@ -6,7 +6,7 @@ import EditorAccessibility from './EditorAccessibility';
 
 describe('<EditorAccessibility />', () => {
   it('renders empty message with no lines', () => {
-    render(<EditorAccessibility lintMessages={[]} />);
+    render(<EditorAccessibility lintMessages={[]} currentLine={0} />);
 
     expect(
       screen.getByRole('listitem', {
@@ -21,11 +21,12 @@ describe('<EditorAccessibility />', () => {
         lintMessages={[
           {
             severity: 'info',
-            line: '1',
+            line: 1,
             message: 'foo',
-            id: '1a2b3c'
+            id: 123
           }
         ]}
+        currentLine={0}
       />
     );
 

client/modules/IDE/components/ErrorModal.unit.test.jsx

@@ -8,20 +8,30 @@ jest.mock('../../../i18n');
 
 describe('<ErrorModal />', () => {
   it('renders type forceAuthentication', () => {
-    render(<ErrorModal type="forceAuthentication" closeModal={jest.fn()} />);
+    render(
+      <ErrorModal
+        type="forceAuthentication"
+        closeModal={jest.fn()}
+        service="google"
+      />
+    );
 
     expect(screen.getByText('Login')).toBeVisible();
     expect(screen.getByText('Sign Up')).toBeVisible();
   });
 
   it('renders type staleSession', () => {
-    render(<ErrorModal type="staleSession" closeModal={jest.fn()} />);
+    render(
+      <ErrorModal type="staleSession" closeModal={jest.fn()} service="google" />
+    );
 
     expect(screen.getByText('log in')).toBeVisible();
   });
 
   it('renders type staleProject', () => {
-    render(<ErrorModal type="staleProject" closeModal={jest.fn()} />);
+    render(
+      <ErrorModal type="staleProject" closeModal={jest.fn()} service="google" />
+    );
 
     expect(
       screen.getByText(

client/modules/IDE/components/FileNode.unit.test.jsx

@@ -83,12 +83,18 @@ describe('<FileNode />', () => {
     });
 
     it('can change to a different extension', async () => {
+      const mockConfirm = jest.fn(() => true);
+      window.confirm = mockConfirm;
+
       const newName = 'newname.gif';
       const props = renderFileNode('file');
 
       changeName(newName);
 
-      await waitFor(() => expect(props.updateFileName).not.toHaveBeenCalled());
+      expect(mockConfirm).toHaveBeenCalled();
+      await waitFor(() =>
+        expect(props.updateFileName).toHaveBeenCalledWith(props.id, newName)
+      );
       await expectFileNameToBe(props.name);
     });
 

server/controllers/project.controller/__test__/createProject.test.js

@@ -179,6 +179,10 @@ describe('project.controller', () => {
     });
 
     it('fails if user does not have permission', async () => {
+      // We don't want to clog up the jest output with extra
+      // logs, so we turn off console warn for this one test.
+      jest.spyOn(console, 'warn').mockImplementation(() => {});
+
       request.user = { _id: 'abc123', username: 'alice' };
       request.params = {
         username: 'dana'

server/controllers/project.controller/createProject.js

@@ -59,7 +59,7 @@ export async function apiCreateProject(req, res) {
 
   const checkUserHasPermission = () => {
     if (req.user.username !== req.params.username) {
-      console.log('no permission');
+      console.warn('no permission');
       const error = new ProjectValidationError(
         `'${req.user.username}' does not have permission to create for '${req.params.username}'`
       );