Fix empty project download #2048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync forked repo
Sync with base repo
Contributor
Author
|
The solution works locally on my machine but fails in CI due to peer dependency errors. Can anyone help me with this so we can get this merged? Thanks |
raclim
approved these changes
Oct 19, 2022
Collaborator
|
I don't see the dependency issues you described; it appears to be working and passed the tests and linting! Thank you so much for your work! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2038
Changes: Updated buildZip and bundleExternalLibs functions in projects controller.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123