All files in download zips are empty (have 0 bytes)

[travelalpaca]

Details about the bug:

• Web browser and version: various flavors of chromium and firefox (both mobile and desktop).
• Steps to reproduce this:

1. Download the project files from the browser.
2. This generates a zip archive
3. The zip archive contains the correct files containing the correct source code inside, however all files within the zip are marked as a size of 0 bytes
4. Some of my archive managers were able to still read the files correctly, despite the apparent 0 B file size. While some of my other archive managers view the files as empty.

I downloaded a project successfully yesterday, then again about 2 hours ago. But right now, all project downloads show files as having 0 Byte size, it doesn't matter if they're my own projects or other projects that have been shared.

[welcome]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

[CaptainCredible]

Can confirm this issue. Tested with chrome on macOS, and chrome, opera , Firefox and edge on win10 all produce zip files containing empty files

[jht1900]

Confirmed same issue on MacOS in Safari and Chrome - downloaded zip file contains all zero length files

[jht1493-gmail]

What does it take to upgrade this to a bug? I'm pretty sure it was not in prior versions of editor. Pretty sure I was downloading ok all of 2021.

[travelalpaca]

What does it take to upgrade this to a bug? I'm pretty sure it was not in prior versions of editor. Pretty sure I was downloading ok all of 2021.

I downloaded a project just fine that same day on July 6, 2022, then two hours later when I downloaded it again the zip archives were messed up, and now three weeks later, export archives are still showing 0 bytes size for all files. So whatever went wrong happened specifically on July 6 -- hopefully that's helpful information to anyone with the ability to make a correction.

Looks like there was quite a lot of activity on July 6: https://github.com/processing/p5.js-web-editor/actions

[dwight9339]

Dove into the code a little bit this afternoon to see if I might be able to help. I think it might be an issue with the archiver package. I'll keep looking into it and report back.

[dwight9339]

So I've got a fix for this working locally on my machine that I'm ready to push but, quick question, is it really necessary to include external libs in the zip? The currently deployed version goes and grabs any external scripts referenced in index.html but most of the time these are CDN hosted scripts anyway so, at least to me, it seems pretty superfluous to include them in the download.

[jht1900]

Personally I would prefer the external scripts to get pulled from the CDN, but would not want to risk a change in behavior now. Fixing the zero length bug should be the first step and CDN extern script option in a separate pull request.

[haschdl]

@dwight9339 thanks for reporting the bug and providing a fix. @jht1900 would you be able to assist in getting #2048 approved and merged? This is a quite important feature of the editor!

[jht1493-gmail]

@dwight9339 thanks for reporting the bug and providing a fix. @jht1900 would you be able to assist in getting #2048 approved and merged? This is a quite important feature of the editor!

I agree this is important feature! I'll ask around for tips on getting approval of fix.

[kjhollen]

hi folks, thank you for your attention on this issue. the editor is currently in maintenance mode as we transition to new leadership (see #2010). hope to have an update next month!

[pierrep]

I understand the editor is in maintenance mode, but this is a critical bug, which should be fixed in a 'maintenance' state. It's not new functionality, it's core existing infrastructure.